Sequelize.VIRTUAL fields are incorrect unless dependent data is explicitly fetched about graphql-sequelize HOT 7 CLOSED

You need to use new Sequelize.VIRTUAL(returnType, [dependencies ... ]). Which was recently added, because how the hell else would graphql-sequelize know what fields to load?

from graphql-sequelize.

https://github.com/mickhansen/graphql-sequelize/blob/master/test/attributeFields.test.js#L83

from graphql-sequelize.

Yeah, that's why I put "bug" in quotes. Is that documented anywhere? I actually just ran across it splunking in the code before reading your comment 😄

from graphql-sequelize.

Hmm, doesn't look like we have a test for VIRTUAL dependencies, only for VIRTUAL return type.
But tests act like documentation for the most part currently while we're still fleshing out APIs.

from graphql-sequelize.

👍 I'll look in there first next time!

from graphql-sequelize.

Following up:

I replaced:

fullName: {
  type: Sequelize.VIRTUAL,
  get: function(): ?string { return `${this.firstName} ${this.lastName}`; },
},

With:

fullName: {
  type: new Sequelize.VIRTUAL(Sequelize.STRING, ['firstName', 'lastName']),
  get: function(): ?string { return `${this.firstName} ${this.lastName}`; },
},

And it worked great! 👏

from graphql-sequelize.

Super :) I've faced the issue myself. (I have a lot of custom boolean logic in virtuals, it was completely screwed).

from graphql-sequelize.