Comments (8)
graphql/graphql-relay-js package actually supports this with their default result parsing feature. I really think that trying to add native postgres query support for this would just result in a slower operation then what is being done already. Added tests for all the mentioned arguments to show it working.
from graphql-sequelize.
Haven't looked at the relay code yet, but i assume it does filtering after the values have been loaded from the database?
So in the case where you have 500 tasks, it will load all 500 and then take N of that? Then it might be good to actually filter in SQL instead.
from graphql-sequelize.
yeah, the filtering is done on the result level - not prior to the data being queried. We'd have to do a deeper integration which we will most definitely want to implement at some point for application speed. Before After also uses a cursor for record parsing so we'd need to really look into how that cursor is generated and apply that our code.
This will be an optimization level feature for our project so it might be a bit before we get to it.
from graphql-sequelize.
I'll likely need it for my project since querying the entire range would be very expensive.
Not sure when i'll switch to Relay queries though since i'm using GraphQL with Angular atm.
from graphql-sequelize.
from graphql-sequelize.
So there's some talk about constructing your own cursors and storing data in them.
For example if paging by say createdAt, each cursor could hold that items createdAt value to easily filter without having to do a subquery lookup.
from graphql-sequelize.
We'll probably need custom logic for all this, and won't be able to use graphql-relay
's connectionFromArray like we currently do (https://github.com/mickhansen/graphql-sequelize/blob/master/src/relay.js#L38).
/cc @aweary @brad-decker
from graphql-sequelize.
from graphql-sequelize.
Related Issues (20)
- Combining multiple associations HOT 5
- Problem integrating connection types and dataloader for paginated (cursor) queries HOT 1
- When using `JSONType` I get `Error: One of the provided types for building the Schema is missing a name.` HOT 2
- Can we use `attributeFields` with graphql SDL? HOT 2
- How to express two way relationship HOT 2
- Change the default name of Date scalar HOT 3
- Relay Connections with Dataloader HOT 4
- Is this working with GraphQL 15? HOT 2
- sequelize model comment => graphql field description HOT 4
- CITEXT throws an issue in the latest version HOT 7
- Unable to convert geometry to graphql type HOT 1
- Are filtering operators supported? HOT 2
- OrderBy can conflicts with Attributes HOT 1
- Passing `where:` in-place, without query variable HOT 2
- Fix order type in defaultListArgs HOT 6
- Compatibility with GraphQL v17 HOT 1
- Peer dependency support for graphql 16 HOT 2
- OrderBy doesn't pass multiple to the query HOT 1
- Changing relay edges to be nonNull causes a node error HOT 3
- Use graphql-sequelize with dataloader-sequelize HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-sequelize.