typeMapper returned ENUM type missing name about graphql-sequelize HOT 16 CLOSED

The typeMapper should probably receive the whole attribute instead of just the type, to get access to the Model's name and the attribute's name.

from graphql-sequelize.

Would not make it a typeMapper anymore though ;)
But we'll probably have to remove ENUM from the typeMapper and do a special case in attributeFields.

from graphql-sequelize.

Does it matter what the name is for the GraphQLEnumType? If we just need to enforce unique names we can generate unique random strings for the name.

from graphql-sequelize.

It will make the returned schema valid again since name's are just required to be unique, but introspection of your schema saying Object x has a field of type "Di57gpl" (random string) isn't very nice.

from graphql-sequelize.

Well, looking nice in introspection is a secondary concern to functionality. So I think what it should do is generate a random string for the schema name, note that it does so in the docs, and if you really need to have specific declared names you can exclude the ENUM and define it yourself.

from graphql-sequelize.

In order to maintain the function of typeMapper only being a typeMapper, we could check to see if the returned type from typeMapper is a ENUM inside of attributeFields and add the name after the fact using key and model name. So something like [modelname][Key]EnumType - (ex: userStatusEnumType) ?

from graphql-sequelize.

The unique name checking takes place inside the GraphQLObjectType constructor so that wouldnt fix the error.

from graphql-sequelize.

The unique name error is thrown from the schema object, not from the GraphQLEnumType/Or Object Types. GraphQL doesn't know its non-unique until you try to build the schema.

from graphql-sequelize.

Error: Schema must contain unique named types but contains multiple types named "undefined".
    at invariant ([...]/node_modules/graphql/jsutils/invariant.js:20:11)
    at typeMapReducer ([...]/node_modules/graphql/type/schema.js:138:41)

from graphql-sequelize.

Ahh, yes I see. Then i'd say run like that. It makes more sense to implement the name logic inside the attributeFields function.

from graphql-sequelize.

@aweary + @mickhansen thoughts on this solution? Requires an additional type check inside of attributeFields which is the only negative.

from graphql-sequelize.

👍

from graphql-sequelize.

@brad-decker Sounds like a good solution for now.

from graphql-sequelize.

@mickhansen i threw the fix for this into my open Pull request. added tests for coverage

from graphql-sequelize.

Published in v0.9.0

from graphql-sequelize.

@mickhansen this should be reopened as the fix does not cover nesting via DataTypes.ARRAY(DataTypes.ENUM(ENUM_ARRAY))

from graphql-sequelize.