BigInt columns should be GraphQLFloat about graphql-sequelize HOT 5 CLOSED

No firm opinion, any clues in the spec?

from graphql-sequelize.

Well the spec specifies that a GraphQLFloat is definitely a FP number-

A Float number includes either a decimal point (ex. 1.0) or an exponent (ex. 1e50) or both (ex. 6.0221413e23).

However, the graphql-js implementation just uses parseFloat

parseFloat(ast.value)

which in our case, passing a large integer value to parseFloat, results in standard integer, e.g.

parseFloat("4121722835") // result: 4121722835
// not
// 4121722835.0

So in order to get a BigInt, it seems we have to use either a custom scalar type or use the Float type because of this behavior. I guess the "cleanest" way to do this would be to implement our own Scalar type called BigInt that doesn't adhere to the GraphQLInt limits. Then the question becomes whether this library starts implementing custom types. In this case, I am leaning towards the custom type as being the best solution...

from graphql-sequelize.

A custom scalar is probably the best way to go if there's no standard way of doing int8

from graphql-sequelize.

The natural mapping would be to GraphQLString wouldn't it? If you need to further play with it on the GraphQL side you can convert to big-integer or float or whatever. My use case is that the BIGINT is a 64-bit integer unique iD, so I'm happy enough with the string representation on the GraphQL side.

from graphql-sequelize.

Yeah I agree with @brainjam after talking it over with Lee byron on the other projects. I will do a PR making GraphQLString the default.

from graphql-sequelize.