Code Monkey home page Code Monkey logo

Comments (5)

mickhansen avatar mickhansen commented on July 22, 2024

Thanks, i will look into it :)

from graphql-sequelize.

amccloud avatar amccloud commented on July 22, 2024

I've looked into this a bit more. The resolve function signature changed in 0.3.0.

Field resolve functions now have a new API: resolve(value, args, info), where info is an object which contains the same information which used to be separate arguments, and includes more useful stuff! https://github.com/graphql/graphql-js/releases/tag/v0.3.0

I've done this in the meantime:

let photoResolver = resolver(Photo);
//...
resolve: (value, args, {rootValue, fieldASTs, returnType}) => {
  return photoResolver(value, args, rootValue, fieldASTs, returnType);
}
//...

from graphql-sequelize.

mickhansen avatar mickhansen commented on July 22, 2024

Ah okay so they mixed root, field and type into one field, should be a pretty trivial fix. Changing https://github.com/mickhansen/graphql-sequelize/blob/master/src/resolver.js#L31 to source, args, {root, ast, type} should work i think.

I'll see if i can't get a fix in today.

Thanks for using this lib @amccloud :)

from graphql-sequelize.

mickhansen avatar mickhansen commented on July 22, 2024

Hmm, quite a few changes in how the AST is passed around now, working on a fix.

from graphql-sequelize.

mickhansen avatar mickhansen commented on July 22, 2024

Should now work in [email protected] do make sure to thoroughly test it though.
fieldASTs is now an array with a single element instead of the single element so i'm doing a naive fix with fieldASTs[0] but all my tests pass (but it's not the most comprehensive test suite in the world).

from graphql-sequelize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.