Comments (5)
Hi
During the tests, I didn't notice any similar problems that you describe. Can you provide more information on your use case?
from accordion.
Hi During the tests, I didn't notice any similar problems that you describe. Can you provide more information on your use case?
Im inited acc on page this code
` const accordionNewItems = [...document.querySelectorAll('.accordion')]
const initedAccordionsItems = accordionNewItems.filter(acc => !acc.classList.contains('not-inited'))
const notInitedAccordionsItems = accordionNewItems.filter(acc => acc.classList.contains('not-inited') &&
!acc.classList.contains('search-form__specialization-accordion'))
initedAccordions = new Accordion(initedAccordionsItems, {
elementClass: 'accordion__item',
triggerClass: 'accordion__head',
panelClass: 'accordion__content',
activeClass: 'active',
openOnInit: [0],
onOpen: (item) => {
const header = document.querySelector('header')
const instanceFromTop = item.getBoundingClientRect().top + window.pageYOffset - header.offsetHeight;
window.scroll({
top: instanceFromTop,
left: 0,
behavior: 'smooth'
});
}
})
`
After on page when user click showMore i start this function
`export function getPriceFromApi(url, btnMore) {
const parentSection = btnMore.parentNode;
getData(url).then((res) => {
if (res.data.prices) {
btnMore.insertAdjacentHTML('beforebegin', res.data.prices)
btnMore.style = "display:none;";
if (res.data.url) {
btnMore.setAttribute('data-url', res.data.url)
btnMore.setAttribute('data-count', res.data.count)
btnMore.style = "display:inline-block;";
}
const accordions = [...parentSection.querySelectorAll('.accordion')];
const parentAccordion = initedAccordions.find(item => item.element == parentSection);
const initedAccordionsElements = initedAccordions.map(item => item.element)
const notInitedAccorions = accordions.filter(item => !initedAccordionsElements.includes(item))
if (notInitedAccorions.length > 0) {
const newAccordionsInited = new Accordion(notInitedAccorions, {
elementClass: 'accordion__item',
triggerClass: 'accordion__head',
panelClass: 'accordion__content',
activeClass: 'active',
onOpen: (item) => {
const header = document.querySelector('header')
const instanceFromTop = item.getBoundingClientRect().top + window.pageYOffset - header.offsetHeight;
window.scroll({
top: instanceFromTop,
left: 0,
behavior: 'smooth'
});
}
})
initedAccordions.push(...newAccordionsInited)
}
parentAccordion.update()
}
})
}`
and when i dell from init accordion func openOnInit: [0] - work well. But if i use with this func on init accordion => when i use update, added element be open.
from accordion.
` createDefinitions() {
const { elementClass, openOnInit } = this.options;
this.elements = Array.from(this.container.childNodes)
.filter((el) => el.classList && el.classList.contains(elementClass));
this.firstElement = this.elements[0];
this.lastElement = this.elements[this.elements.length - 1];
console.log(this.elements);
this.elements
.filter((element) => !element.classList.contains(`js-enabled`))
.map((element, idx) => {
// When JS is enabled, add the class to the element
element.classList.add('js-enabled');
this.generateIDs(element);
this.setARIA(element);
this.setTransition(element);
console.log(element);
console.log(` includes`);
console.log(openOnInit.includes(idx));
uniqueId++;
return openOnInit.includes(idx) ? this.showElement(element, false) : this.closeElement(element, false);
});
},`
in this you start openOnInit.includes(idx). This always be true for 0 if i use openOnInit[0],
from accordion.
Yea, you have right. I will fix it this week
from accordion.
Fixed in v3.3.0
from accordion.
Related Issues (20)
- How to reinitialization accordion when loading new accordion elements? HOT 7
- Adding/removing an attribute from the button + edit the general structure HOT 3
- Missing CDN link to js file in demo page HOT 2
- Remove constraint that accordion items must be direct children of the accordion container HOT 6
- Responsive initialization HOT 3
- An option to disable default styling. HOT 4
- Issues with `closeAll()` method HOT 3
- Incorrect animation height when using beforeOpen to lazyLoad Content HOT 3
- Any way to make the accordion open upwards? HOT 1
- Any way to move the icon to the left? HOT 2
- Feature request: Scroll to the top of the open accordion. HOT 1
- Active State after 'openOnInit' HOT 3
- onOpen() and onClose() are not called when duration is 0 HOT 1
- Existing id attributes are overwritten HOT 1
- Class names are not escaped in selectors
- onClose is triggered on all ancestors of a closed panel HOT 1
- Is there any way to target an accordion by ID? HOT 1
- Accordions not expanding consistently (on mobile) HOT 4
- using an anchor as a trigger not possible HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accordion.