Segmentation fault in SysBus::read_8 about rustboyadvance-ng HOT 11 CLOSED

I did a valgrind run, doesn't reveal more than the gdb backtrace. Valgrind also shows that the yaml crate used by the emulator is unsound, but that's out of the scope of this issue.

from rustboyadvance-ng.

It's crashing on trying to read BIOS address 00950209.

from rustboyadvance-ng.

Could be open-bus related ?

from rustboyadvance-ng.

I tested it, open-bus seems to solve this one too with that new if addr > 0x3fff check.

from rustboyadvance-ng.

So I guess that it will be solved after #109 is merged

from rustboyadvance-ng.

Looks like there are still segfaults in other places after open-bus (crashing 16-bit writes to iodev). I think I'll investigate them later in an another issue.

from rustboyadvance-ng.

For starters, we could replace all get_unchecked to get sensible panics instead of segfaults.
(I only put these to avoid size checks at runtime)

from rustboyadvance-ng.

Or change them conditionally with #[cfg(debug_assertions)] so release builds doesn't get a performance hit.

from rustboyadvance-ng.

Well I found out why I was getting segfaults on the open-bus branch. I was an idiot and forgot to call gba.init(); in my test bench. Everything works flawlessly when things are initialized. The constructor of GameBoyAdvance could benefit from some more defensive approach to initialization to avoid mistakes like that (builder pattern or calling .init() in ::new(), etc.).

from rustboyadvance-ng.

Oh yeah, that's what I meant that the branch isn't polished. the .init() thing is a dirty hack I'll get around when I merge this.

Since moving to pointer territory I get reminded why I hate modern compilers.

Calling Gba::init (which basically passes its pointer to SysBus) inside Gba::new isn't working (at least in windows), since the compiler moves the Gba allocation after returning from Gba::new, so the pointer is made stale.

Is there a way to pass weak references to owned structs in rust that doesn't involve completely redesigning the project?

from rustboyadvance-ng.

fixed in c8d5094

from rustboyadvance-ng.