Comments (6)
from decorator.
Hi, thanks for the quick reply !
I am not sure I understood your answer correctly. Or maybe it did not explain well enough what I want to achieve. With this optional argument I want to able to either use the decorator as @printer
or @printer("some string")
.
I adapted my code following your remark (I also renamed the inner _printer
function to inner_printer
for clarity's sake):
import decorator
def _printer(text=None):
def _inner_printer(func, *args, **kwargs):
if text:
print(text)
func(*args, **kwargs)
return decorator.decorator(_inner_printer)
printer=_printer()
@printer
def world():
print("World")
@printer("Goodbye")
def universe():
print("Universe")
The thing is that the function world
gets decorated correctly but universe
breaks the interpreter at definition time with the following error.
Traceback (most recent call last):
File "toto.py", line 15, in <module>
@printer("Goodbye")
File "<decorator-gen-1>", line 2, in _inner_printer
File ".../lib64/python3.4/site-packages/decorator.py", line 240, in decorate
evaldict, __wrapped__=func)
File ".../lib64/python3.4/site-packages/decorator.py", line 215, in create
name, rest = obj.strip().split('(', 1)
ValueError: need more than 1 value to unpack
Did I misunderstood your solution ? Could you correct my code ?
from decorator.
Stumbled on using optional decorator arguments, and found no docs on this.., came up with this solution:
*Note that this works for optional arguments, but limits you to use kwargs only.
import decorator
def printer(_func=None, text='blah'):
def _printer(func, *args, **kwargs):
if text:
print(text)
func(*args, **kwargs)
if _func:
return decorator.decorate(_func, _printer)
return decorator.decorator(_printer)
@printer
def world():
print("World")
@printer(text='Hello')
def hello():
print("World")
world()
hello()
I suggest adding a section on optional arguments to the docs.
from decorator.
This is a creative solution that works. Still, I do not like the whole idea, too much magic. What's wrong with having two parenthesis at the end of the decorator? Using printer()
to me looks a lot clearer.
from decorator.
I agree with the "not too much magic" statement. I will use empty parenthesis though but thanks for the proposal.
I just asked this question in the first place in case i had missed something about how to use decorators. It finally seems that this is not a lack of knowledge but just some kind of edge case. Thanks for your time guys. For me, the ticket can be closed.
from decorator.
@neimad1985 since PEP 557 has been accepted (https://www.python.org/dev/peps/pep-0557) I have given up. If Guido thinks that it is fine to drop the parenthesis in a decorator factory, then it is fine. Starting from today (release 4.2.0) the following code is valid and does what you want:
@decorator.decorator
def printer(func, text='hello', *args, **kwargs):
print(text)
return func(*args, **kwargs)
@printer
def world():
print("World")
from decorator.
Related Issues (20)
- pylint warning W1113: keyword-arg-before-vararg HOT 1
- Regression in 5.1.0 - decorator.contextmanager no longer compat with contextlib.contextmanager HOT 4
- `FunctionMaker.create()` fails when given a function definition with a return type annotation. HOT 1
- Functionmaker.create (from doc example) fails with kwarg-only functions HOT 6
- `FunctionMaker.create` raises unexpected SyntaxError when return is present as substring for async function
- How to make `@decorator` with other decorators? HOT 3
- TypeError: missing 1 required positional argument HOT 1
- <=3.4.2 can't be installed with modern setuptools HOT 2
- Continuous fuzzing by way of OSS-Fuzz
- compatibility issue with kwargs HOT 2
- Not preserving low level signature metadada HOT 1
- decorator whether to support decorator partial functions?
- Confusion about license using HOT 1
- Making __name__ optional attribute of decorated-function if underlying function is missing it. HOT 3
- Compatibility with Python 3.12 - RuntimeError: There is no current event loop in thread 'MainThread'.
- Unable to pull 4.4.2 from the repo only pulls in 4.2.1 HOT 1
- [BUG] kwargs are not respected HOT 3
- Create SECURITY.md
- Create a decorator for both sync and async function HOT 1
- Erroneous `%` ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from decorator.