Gjs-WARNING: The GObject property St.ScrollView.[hv]scroll is deprecated (in GNOME 46) about dash-to-dock HOT 8 CLOSED

@vanvugt can you check the PR? that should be the last issue for the gnome 46 release :)

from dash-to-dock.

This is odd... neither the documentation nor the Gnome Shell source code do mark those properties as deprecated...

from dash-to-dock.

$ grep -B4 DEPRECATED *
...
--
st-scroll-view.c-    g_param_spec_object ("hscroll",
st-scroll-view.c-                         "StScrollBar",
st-scroll-view.c-                         "Horizontal scroll indicator",
st-scroll-view.c-                         ST_TYPE_SCROLL_BAR,
st-scroll-view.c:                         ST_PARAM_READABLE | G_PARAM_DEPRECATED);
--
st-scroll-view.c-    g_param_spec_object ("vscroll",
st-scroll-view.c-                         "StScrollBar",
st-scroll-view.c-                         "Vertical scroll indicator",
st-scroll-view.c-                         ST_TYPE_SCROLL_BAR,
st-scroll-view.c:                         ST_PARAM_READABLE | G_PARAM_DEPRECATED);
--
...

from dash-to-dock.

Oh! I was searching for something in the comments... Now it makes sense.

from dash-to-dock.

(also, I searched in lowercase 🤦🏾‍♂️)

from dash-to-dock.

Am I correct in seeing that this is the only place this occurs?:

From what I can tell, it should be possible to just access scrollView.vAdjustment and scrollView.hAdjustment directly instead of going through vscroll and hscroll.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3020/diffs?commit_id=d243a9ba9320971d5ce8524ff8355b24606d9420

That seems to be why they got deprecated it in the first place:

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3020

from dash-to-dock.

@K1ngjulien You are right. I left a comment in your PR, but in overall, it looks good.

from dash-to-dock.

Closed in #2185.

from dash-to-dock.