michalboska / rust-developer Goto Github PK

View Code? Open in Web Editor NEW

0.0 2.0 0.0 1005 KB

Rust 99.15% JavaScript 0.52% Dockerfile 0.33%

rust-developer's Introduction

Rust developer

Nothing here… yet

rust-developer's People

Watchers

rust-developer's Issues

Minor feedback

rust-developer/ex09_networking/src/main.rs

Lines 79 to 85 in 8e594c3

    
           let message_option = match stream.borrow_mut().read_next_message() { 
        
               Err(_) => { 
        
                   break; 
        
               } 
        
               Ok(Some(msg)) => Some(msg), 
        
               _ => None, 
        
           };

This could be a if-let-else :)

rust-developer/ex09_networking/src/main.rs

Line 105 in 8e594c3

if let Err(_) = result {

use .is_err() if you do not care about the contents of the Err

Your RuntimeError type is nice :)

rust-developer/ex09_networking/src/err.rs

Lines 3 to 4 in 8e594c3

    
           use std::fmt; 
        
           use std::fmt::Formatter;

This could be simplified to use std::fmt::{self, Formatter}

rust-developer/ex09_networking/src/cli.rs

Lines 14 to 17 in 8e594c3

    
           pub enum Modes { 
        
               CLIENT, 
        
               SERVER, 
        
           }

In Rust, the convention is to use UpperCamelCase for enum variants, but no big deal

Malý feedback

rust-developer/ex02_slugify/src/main.rs

Line 19 in 162e64d

return match operation.as_str() {

Nešlo by se tomuhle vyhnout a rovnou brát &str v tý funkci?

On the topic of debuggers

rust-developer/hello_world/src/main.rs

Line 4 in 162e64d

    
           let random_val = random::<u8>(); // temporary assignment to a variable to test the debugger.

If you like to experiment with debuggers, also checkout rr (https://rr-project.org/) it works with Rust, and you can test with it that nothing will be random in your app anymore :D

Minor feedback

rust-developer/ex07_threading/src/commands.rs

Line 19 in 8206738

PoisonPill,

I love the name and creativity of the poison pill :D

The usage of the pad crate is also a great idea

Extra info

rust-developer/ex05_err_handling/src/csv_table.rs

Lines 26 to 28 in 8889503

    
           if PRINT_ROW_SEPARATORS { 
        
               f.write_str(&spacing_row)?; 
        
           }

You can also use features and cfg_if :) I can show you, if you want

michalboska / rust-developer Goto Github PK

rust-developer's Introduction

Rust developer

rust-developer's People

Watchers

rust-developer's Issues

Minor feedback

Malý feedback

On the topic of debuggers

Minor feedback

Extra info

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	let message_option = match stream.borrow_mut().read_next_message() {
	Err(_) => {
	break;
	}
	Ok(Some(msg)) => Some(msg),
	_ => None,
	};