Code Monkey home page Code Monkey logo

Comments (6)

anuraghazra avatar anuraghazra commented on August 25, 2024 1

looks like using === is causing the issue because it doesn't take account on www

  return (
    host === 'youtu.be' ||
    (host === 'youtube.com' &&
      pathname.includes('/watch') &&
      Boolean(searchParams.get('v')))
  );

from gatsby-remark-embedder.

anuraghazra avatar anuraghazra commented on August 25, 2024 1

so basically all new URL(url).host === "my url" checks will be failing in this case

from gatsby-remark-embedder.

MichaelDeBoey avatar MichaelDeBoey commented on August 25, 2024

Hi @anuraghazra!

Thanks for bringing this to my attention.
Will push a fix asap. 🙂

from gatsby-remark-embedder.

MichaelDeBoey avatar MichaelDeBoey commented on August 25, 2024

@allcontributors Please add @anuraghazra for bugs

from gatsby-remark-embedder.

allcontributors avatar allcontributors commented on August 25, 2024

@MichaelDeBoey

I've put up a pull request to add @anuraghazra! 🎉

from gatsby-remark-embedder.

MichaelDeBoey avatar MichaelDeBoey commented on August 25, 2024

🎉 This issue has been resolved in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

from gatsby-remark-embedder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.