Code Monkey home page Code Monkey logo

Comments (23)

mhinz avatar mhinz commented on May 18, 2024

Hey,

thanks for the feedback. I'm looking into it.

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

Try: git fetch && git checkout buffer-improvements

Now there should be only one new split, which is a blank scratch buffer, right?

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

@mhinz Sweet! The buffer-improvements branch fixed it. When are you going to merge it in into master?

Following the steps above, after executing step 3, there's only supposed to be the ONE window; the startify scratch buffer. After hitting Enter to select another buffer, there should now be two windows (one tiny MiniBufExpl and the main editor window with the new buffer).

Anyway, looks like you fixed the issue. Thanks!

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

@mhinz hmm I spoke to soon. I'm still able to reproduce it, but not as easily. Let me find the steps to reproduce it again.

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

Yup, I knew it wouldn't fix it for all cases.

I tell you from experience, the hardest part about plugin development is not the functionality itself, but getting it compatible to other plugins. Most of the time interferring autocmds are the reason. And fixing stuff for one plugin breaks it for 2 others. It's a vicious circle.

I'll try to come up with a proper solution anyway!

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

@mhinz thank you. I really like this plugin and it would be great if you could find the proper solution.

Updated steps for the buffer-improvments branch. It's not 100% reproducible (which is weird)

  1. Start vim
  2. Open any recent file from Startify Menu (I use Enter)
  3. Open startify again (:Startify)
  4. Select another recent file from Startify Menu (two windows: one line MBE window + main editor)
  5. Delete this buffer (:bd). The MBE window auto-closes since there is only one buffer.
  6. Open startify again (:Startify)

It looks like this again: http://d.pr/i/g9nx. If unable to reproduce on first try, try repeating steps 3 through 6 a couple times. Thanks again!

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

I pushed another commit to buffer-improvements. It still has some bugs, but should work better now.

I'll be at the Baltic Sea over the weekend, so the next patches will arrive at Sunday.

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

@mhinz Cool thanks!

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

Can you still reproduce the above mentioned bug with this version?

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

No, it's worse in the buffer-improvements branch =/

Hitting Enter to select a buffer from the Startify results in a new "empty buffer". Using CtrlP from the startify results in a new vertical window--side-by-side with the Startify window.

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

The former is the bug mentioned in the commit message. Selecting via number should work, selecting via <cr> fails.

For me it also fixes the MBE issue. And NERDTreeToggle works properly too. I'll look into ctrlp at Sunday.

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

Sorry, I didn't read the commit comment. Yes, selecting via number works!
Thanks.

On Thu, Jul 25, 2013 at 5:33 PM, Marco Hinz [email protected]:

The former is the bug mentioned in the commit message. Selecting via
number should work, selecting via fails.

For me it also fixes the MBE issue. And NERDTreeToggle works properly too.
I'll look into ctrpl at Sunday.


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-21594507
.

from vim-startify.

freeo avatar freeo commented on May 18, 2024

I'm using
https://github.com/fholgado/minibufexpl.vim NOT techlivezheng

branch: startify-master 28.7.2013

Buffers disappear after being opened with startify, NERDTree creates 2 vert and 3 horz windows and can't 'q' it.
4 Buffers max, can't open more.

Reproduced Saamaliks screenshot 2x times by accident, can't reproduce at will.

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

Techlivezheng is the maintainer for MBE. All releases are pushed to fholgago, so in essence thetechlivezheng is the latest and greatest.

I don't think that setting any arbitrary buffer without a file type detected to ft=startify is the right solution. @mhinz already fixed most of these issues on the branch and I'll wait for him to fix the last CR issue as well :-)

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

Yup, I'll care about this tomorrow. I'm just back from the Baltic Sea (with sunburn of course) and need some sleep to prevent myself from comitting weird code.

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

@mhinz Sweet. Hope you had a good time!

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

(Thanks, I had a lovely time there!)

Selecting via <cr> should work right now.

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

This last commit should fix those nasty empty buffer bugs.

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

This works now:

1)  $ vim  (run vim)
2)  vjv<cr>  (open the 2 most recent files in vertical split)
3)  :Startify<cr>  (rerun startify)
4)  jsjsjv<cr>

Afterwards it should look like this (well, it depends on some options):

layout

Please try to break it now. :-)

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

@mhinz dude you rock. I tried for 5 minutes with complex window/buffer/ex incantations but was the functionality worked perfectly.

The only MINOR issue I found with CtrlP:

  1. Start VIM
  2. Instead of using using Startify to open buffer, use CtrlP to edit a file.
  3. The selected file opens in a vertical split window.

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

Yup, I can reproduce that. I'll look into it, but I think it's something that ctrlp should handle on its side.

If I choose not to include a compliced exception for ctrlp, I'll open an issue report for ctrlp.

from vim-startify.

saamalik avatar saamalik commented on May 18, 2024

Sounds good. Thanks again!
On Jul 29, 2013 1:05 PM, "Marco Hinz" [email protected] wrote:

Yup, I can reproduce that. I'll look into it, but I think it's something
that ctrlp should handle on its side.

If I choose not to include a compliced exception for ctrlp, I'll open an
issue report for ctrlp.


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-21747211
.

from vim-startify.

mhinz avatar mhinz commented on May 18, 2024

I'm glad you like the plugin! I merged the fixes into master now.

from vim-startify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.