Comments (4)
Thanks for the report! The fix will be in the next grunt-ng-annotate version.
from grunt-ng-annotate.
Thank you!
from grunt-ng-annotate.
This change broke my build after updating grunt-ng-annotate. I run jshint on the output from this task and it doesn't like ";;" and has no option to specifically ignore double semicolons. And while I'm not super opinionated about it, my understanding is that defensive semicolons are not a good practice.
I'd argue that it should at least be configurable. For example, grunt-contrib-concat has a "separator" option that when set to ";" will insert a defensive semicolon, but by default it doesn't insert anything.
Btw, thank you for maintaining this excellent tool. I am extremely appreciative of your work.
from grunt-ng-annotate.
I've submitted a pull request that allows for specifying a separator to be inserted between concatenated files.
If this change is accepted it may cause a problem for you flipjs, since the default behavior of grunt-ng-annotate would be no separator.
from grunt-ng-annotate.
Related Issues (20)
- Can we ignore files in globbing? HOT 6
- Task appends to existing file instead of rewriting it HOT 3
- timeline for 2.0.0 release HOT 3
- how ng-annotate check if it is an angular-based js? HOT 1
- ngAnnotate fails on es6 classes that have a constructor but no methods HOT 1
- Missing rule HOT 1
- ngAnnotate:dist - Error when parsing .tmp file HOT 7
- Error at annotated vendor HOT 6
- Could we please get a new release for more recent ng-annotate version HOT 1
- upgrade to 2.0.1 then "customizer is not a function" HOT 4
- angular 1.5 component definition breaks ng-annotate. HOT 2
- About angular-bootstrap $uibmodal resolve annotate! HOT 3
- Angular 1.5.8 component template ng-inject HOT 1
- Need support for Angular 1.5 component's controller HOT 1
- Conditional Files HOT 2
- separator option ignored? HOT 2
- Getting Strict mode error on latest version HOT 4
- Doesn't seem to annotate inline controllers? HOT 1
- ng-Annotate HOT 5
- ngAnnotate:dist - Error of parsing during build HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grunt-ng-annotate.