Code Monkey home page Code Monkey logo

Comments (4)

mgol avatar mgol commented on September 2, 2024

Thanks for the report! The fix will be in the next grunt-ng-annotate version.

from grunt-ng-annotate.

flipjs avatar flipjs commented on September 2, 2024

Thank you!

from grunt-ng-annotate.

areologist avatar areologist commented on September 2, 2024

This change broke my build after updating grunt-ng-annotate. I run jshint on the output from this task and it doesn't like ";;" and has no option to specifically ignore double semicolons. And while I'm not super opinionated about it, my understanding is that defensive semicolons are not a good practice.

I'd argue that it should at least be configurable. For example, grunt-contrib-concat has a "separator" option that when set to ";" will insert a defensive semicolon, but by default it doesn't insert anything.

Btw, thank you for maintaining this excellent tool. I am extremely appreciative of your work.

from grunt-ng-annotate.

areologist avatar areologist commented on September 2, 2024

I've submitted a pull request that allows for specifying a separator to be inserted between concatenated files.

#28

If this change is accepted it may cause a problem for you flipjs, since the default behavior of grunt-ng-annotate would be no separator.

from grunt-ng-annotate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.