Make `fill_inplace` take an &mut str about textwrap HOT 3 CLOSED

I just looked at this and I now remember why fill_inplace takes a &mut String instead of &mut str: I cannot find a suitable into_bytes method for &str.

There is a as_bytes_mut method, but it is unsafe. Have I missed some other option to convert a &str into [u8] in-place?

from textwrap.

I don't think there's a way to do this using just the standard library without unsafe. I created the with-str-bytes crate to allow this to be performed safely, if you don't mind another dependency (it's tiny - the entire crate including tests is just 132 lines).

from textwrap.

Hey @Kestrer, okay, good to hear that I probably didn't miss anything here. Sorry for the late responses, recently I've found little time for open source work.

I'll pass on adding a new dependency for this — while it would be pretty if the signature was &mut str, I don't think it's a huge problem that the function demands a String.

from textwrap.