Comments (4)
Ok, I'll change that. Do you have any other ideas of how to improve readability
of the error messages? (I'll commit that once you answer)
Original comment by [email protected]
on 9 Apr 2011 at 12:19
- Changed state: Started
- Added labels: Type-Enhancement
- Removed labels: Type-Defect
from lightopenid.
Well, I would understand these error messages better. I hope I understood the
error messages correct:
l. 79: 'You must have either https wrappers or curl enabled.' -> 'You must have
either https wrappers or cURL enabled. cURL is a command line tool for
transferring files.' (what are https wrappers?)
l. 201: 'Invalid request.' -> 'Invalid request. Host
"http://martin-thoma.blogger.com" doesn't exist.'
l. 463: 'No servers found!' -> 'No OpenID-Server found at "http://blogger.com".
Perhaps you have misspelled your OpenID?'
l. 465: 'Endless redirection!' How can this happen?
Original comment by [email protected]
on 11 Apr 2011 at 6:26
from lightopenid.
Ad l. 79: I expect that people who don't know about something in php itself
will search for it in the docs. For example:
http://php.net/wrappers
http://php.net/curl (also, while curl is a very useful command-line tool, it's
also a library -- and that's how it's used in LightOpenID)
As I don't explain what is a OpenID (and some people using the library *don't*
know that), I don't see a point in explaining every configuration detail of
php. Especially since most default configurations already have both enabled,
and if you have neither, you usually can't do anything about it.
Ad l. 201: Changed to "Could not connect to $url.", Although the $url can be
any url in the path.
Ad l. 463: Will be the first sentence of your suggestion.
Ad l. 465:
If you visit a url, let's say `http://example.com/openid`, and it has a header
"Location: /openid", then LightOpenId follows to `http://example.com/openid`
again. This way, a cycle is created and it would cause an infinite loop. That's
why (as Yadis specification suggests) I throw an exception after 5 redirects.
Original comment by [email protected]
on 11 Apr 2011 at 10:35
from lightopenid.
Original comment by [email protected]
on 21 Apr 2011 at 7:18
- Changed state: Fixed
from lightopenid.
Related Issues (20)
- add composer support HOT 1
- wrong mimetype check in openid.php ? HOT 3
- Use Steam as provider HOT 1
- #-comments HOT 6
- returning clamed_id is a wrong approach HOT 5
- magic get/set methods HOT 3
- LightOpenID magic properties do not work with Twig template engine due to lack of __isset
- New release HOT 2
- keep waiting for localhost HOT 2
- Validation fails when there are accent in the required variable HOT 2
- Yahoo OpenID not working on newer versions of PHP/cURL [patch proposed]
- The regular expressions in htmlTag parse some valid responses incorrectly
- Support for OpenID Connect? HOT 2
- How to select eid applet language ? HOT 1
- Unregistered domain error HOT 1
- (LightOpenId) eID-Applet does not return some eid's data ...
- gitorious no longer existing HOT 5
- Tag a release? HOT 1
- PHP 7.4.0 - get_magic_quotes_gpc() function is deprecated.
- PHP 8.0.3 - Deprecated: Required parameter $update_claimed_id
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightopenid.