Code Monkey home page Code Monkey logo

Comments (5)

denihs avatar denihs commented on June 2, 2024 1

I could reproduce this as your description suggests. The strange part is that we didn't have any more reports on this... I did some debugging but I couldn't find the root cause of this. I'm going to have another go at it later.

from meteor.

paulincai avatar paulincai commented on June 2, 2024

@acemtp how about you take it down as a local NPM package and try one of 2 things:

  1. Delete the peerDependencies (assuming you already have React in your project)
  2. Update the peerDependencies to take from React 18 instead of >=17
    https://github.com/facebook/lexical/blob/main/packages/lexical-react/package.json

from meteor.

acemtp avatar acemtp commented on June 2, 2024

@paulincai i never did meteor npm package so not sure how to take it down as a local npm package.

this is a minimal reproduction repo to make it easier to debug. But in our project, the sakod:core meteor package contains tons of meteor stuffs that we want to keep in a meteor package.

from meteor.

paulincai avatar paulincai commented on June 2, 2024

ok, I think your problem could be related to this: facebook/lexical#5996 and not related to Meteor bundling tools.

This explains how to depend, in a Meteor package, on a local NPM package: meteor/guide#682
To create a local NPM package, just copy an NPM package in a local folder in your project and reference it in either the global package.json of your project "@pampam/packagename": "file:folderLocation/FolderOfThePackageWhichContainsPackageDotJson", or in a Meteor package.

from meteor.

acemtp avatar acemtp commented on June 2, 2024

Thanks you for your reply.

If it's a lexical issue, since we use the same version, why it works with Meteor 2 and not Meteor 3? Could it be due to a change with node version or node modules management?

from meteor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.