collection hooks with collection2 0.3.0 upgrade breaks insert even with no hooks defined about meteor-collection2 HOT 14 CLOSED

Yeah, there is a somewhat significant issue with the code, and this is likely related. I'm working on a fix.

from meteor-collection2.

No problem, thanks for the update.

from meteor-collection2.

0.3.2 still has this issue. Insert still throws an exception due to validation context being put in args[1], pushing the function collection hooks expects in args[1] to args[2]. Update & Delete work as expected.

from meteor-collection2.

@aldeed strange & technically off topic, but, I don't seem to be able to re-open this issue, seems like I should be able to, not sure what github's thinking is on this.

from meteor-collection2.

trying 0.3.3 now...

from meteor-collection2.

Yeah, my first fix was faulty. 0.3.3 should work.

from meteor-collection2.

Still doesn't work. The insert succeeds on the server with no exceptions thrown, the exception in question is thrown on the client only.

from meteor-collection2.

Hmm, maybe this issue is different. If you put collection-hooks before or after collection2 in your packages list, does it make any difference?

from meteor-collection2.

Doesn't appear to make a difference.

from meteor-collection2.

OK, there is a tiny change that can be made to the collection-hooks package to fix this. I'll do a PR for it.

It seems collection-hooks is always being loaded after collection2, so the extra options argument is still there when collection-hooks does its thing. By switching CH to use the last arg as the callback instead of the second arg, this is fixed. That's more future-proof for CH, anyway.

from meteor-collection2.

Ok, so I tested with your fork of collection-hooks and while that particular issue is resolved the error messages are not displaying because the validation is happening against the default context instead of the context specified by the autoForm id. Seeing as the args[1] collection-hooks with tripping on was the expected validationContext I'm guessing this is a related issue. Same autoForm, works without issue on update case.

from meteor-collection2.

Hmm, yes, I see the issue.

from meteor-collection2.

Can you test with my fork now? I think it will work now.

from meteor-collection2.

looks good, thank you

from meteor-collection2.