Queued Requests should be flushed when a dapp connects or disconnects. about core HOT 5 CLOSED

update: It shouldnt matter in relation to connecting, only disconnecting.

from core.

another update: there is currently a bug where if you call revokePermissions while there is a pending confirmation, the confirmation is not cleared.

This applies when either queueing is enabled or disabled.

from core.

Todo:

• if a dapp disconnects, but theres requests from several dapps, when the queueing is turned off it will clear all requests (not just the ones for the currently focused dapp)
• with queuing on, it will clear only the requests for the dapp who was disconnected

from core.

Questions:

• how should we trigger the flushing / clearing of pending confirms? Should we listen to changes on permissionController, or directly call a method/helper from inside the revokePermissions handler? -> the stateChange event should do the trick, but I really think we should be cautious of using patches for this one.
• When a dapp disconnects, aka the permissions are removed for the dapp, are we currently unsetting / deleting the value stored for the domain in the selectedNetworkController? This would cause SelectedNetworkController:stateChange to fire, which is currently handled in QueuedRequestController as a means of deciding when to flush the queue. Its possible that we just need to appropriately handle the patch for the network selection removal (or better yet, check in the selectedNEtworkController state to see if theres any network selection). In addition, we could also handle clearing the non-queued requests in this same handler (basically just copy/call this code)

from core.

When a dapp disconnects, aka the permissions are removed for the dapp, are we currently unsetting / deleting the value stored for the domain in the selectedNetworkController?

yes we are here:

from core.