Comments (2)
Part of me feels like the TransactionController's state shouldn't be limited to the transactions corresponding to the currently-selected address and the current network. This seems like something that downstream applications should handle when rendering a transaction list if they desire, and that the controller should always maintain all transactions a user has sent.
FWIW, we already only check the current network ID from the NetworkController when updating transaction statuses.
from core.
We are migrating away from the old controller composition system, so this is now obsolete.
from core.
Related Issues (20)
- [composable-controller] Non-controllers with empty state should be rejected or excluded from composed state
- [base-controller] Extract `MessengerConsumer` as parent class to `BaseController` and all stateless non-controllers
- [composable-controller] Fix `BaseControllerV1Instance` type and make `ChildControllers` a required type parameter
- `Contract` class `balances` method calls are typed as implicit `any`
- [`preferences-controller`] `@metamask/keyring-controller` should be a runtime dependency, not a development dependency
- Fix `messenger` type naming in BaseControllerV2
- [network-controller] Add `lookupNetwork` timeout
- [base-controller] Controller constructors accept messengers that do not allow any of its internal actions and/or events
- Refactor polling controllers to remove legacy polling patterns and method usage
- [base-controller,polling-controller] Make non-controller superclass compatible with polling-controller mixins
- Add guidelines for writing controllers, and add example controller
- Bump TypeScript module output options `target` and `lib` to `ES2022`
- Support for EIP-5630 urgently needed since eth_getEncryptionPublicKey was deprecated HOT 1
- Add export for TokenBalancesControllerState type on assets-controllers
- Rename ControllerMessenger to Messenger, RestrictedControllerMessenger to RestrictedMessenger
- ESLint behaves differently on different system HOT 4
- [transaction-controller] Boundless growth of transaction history HOT 3
- Adapt EIP 1193 - AssetsContractController
- Adapt EIP 1193 - TokensController
- Network controller state can be corrupted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.