Comments (7)
As far as I can tell, this bug is still valid, and should be reopened. @Ajedi32, the code you linked to seems to be on a different fork. Unless I'm missing something, that code isn't in master, at the moment.
from permalinks.
That code is on master: https://github.com/leolabs/metalsmith-permalinks/blob/master/lib/index.js#L81-L83
Are you using the version from master? Or are you using the latest stable release?
from permalinks.
The permalink front-matter is a boolean value, eg...
---
title: "Hello Metalsmiths"
permalink: true
---
The URL is determined by the filename, just like all other pages.
Please close this issue.
from permalinks.
@Ajedi32 - The code does seem to be in master. My mistake and sorry for the confusion.
Closing issue. I'll evaluate my local env issues.
@doublejosh The readme.md example doesn't show it as a Boolean:
https://github.com/segmentio/metalsmith-permalinks/#overriding-the-permalink-for-a-file
from permalinks.
Huh, you're right. The docs do show it as both boolean (using the false case to exclude) AND a string to explicitly name the desired path. I had only used the boolean case.
Good luck, please let us know what you find.
from permalinks.
It definitely was on master. Here's the commit: d5f5070 Merged with PR #65.
That code seems to have been removed since then though, in deaa8b9.
from permalinks.
Root cause seems to be that the code was removed when #69 was rebased, and nobody noticed because there were no tests for that feature. To prevent this from happening again, any future fixes for this issue should include tests.
from permalinks.
Related Issues (20)
- Add coverage
- Replace substitute package HOT 1
- unique option output (both default & custom) are hard to control. HOT 1
- Default linkset options overwrite further linksets
- Org migration alignment
- Get rid of unmaintained substitute dependency
- Generate an SEO inner link when we don't need it HOT 2
- Provide dual ESM/CJS build
- permalinks 3.0.0 roadmap
- Replace momentjs with alternative HOT 1
- Deprecate (and remove?) the "relative" option
- Using date in linksets throwing an exception HOT 2
- options unique & duplicatesFail overlap in functionality
- v2.5.0 broke the `slug` option HOT 7
- `path` or `permalink` not added to file’s metadata HOT 4
- `path` or `permalink` not added to file’s metadata HOT 2
- [question] aftert or before metalsmith-markdown? HOT 2
- "µ" should not appear in a url HOT 3
- 2 tests failing on clean 2.2.0 repo HOT 1
- Colon in pattern causes crash or hanged process HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from permalinks.