Code Monkey home page Code Monkey logo

Comments (7)

JonathanReeve avatar JonathanReeve commented on June 12, 2024 1

As far as I can tell, this bug is still valid, and should be reopened. @Ajedi32, the code you linked to seems to be on a different fork. Unless I'm missing something, that code isn't in master, at the moment.

from permalinks.

Ajedi32 avatar Ajedi32 commented on June 12, 2024

That code is on master: https://github.com/leolabs/metalsmith-permalinks/blob/master/lib/index.js#L81-L83

Are you using the version from master? Or are you using the latest stable release?

from permalinks.

doublejosh avatar doublejosh commented on June 12, 2024

The permalink front-matter is a boolean value, eg...

---
title: "Hello Metalsmiths"
permalink: true
---

The URL is determined by the filename, just like all other pages.

Please close this issue.

from permalinks.

lokesh avatar lokesh commented on June 12, 2024

@Ajedi32 - The code does seem to be in master. My mistake and sorry for the confusion.

Closing issue. I'll evaluate my local env issues.

@doublejosh The readme.md example doesn't show it as a Boolean:
https://github.com/segmentio/metalsmith-permalinks/#overriding-the-permalink-for-a-file

from permalinks.

doublejosh avatar doublejosh commented on June 12, 2024

Huh, you're right. The docs do show it as both boolean (using the false case to exclude) AND a string to explicitly name the desired path. I had only used the boolean case.

Good luck, please let us know what you find.

from permalinks.

Ajedi32 avatar Ajedi32 commented on June 12, 2024

It definitely was on master. Here's the commit: d5f5070 Merged with PR #65.

That code seems to have been removed since then though, in deaa8b9.

from permalinks.

Ajedi32 avatar Ajedi32 commented on June 12, 2024

Root cause seems to be that the code was removed when #69 was rebased, and nobody noticed because there were no tests for that feature. To prevent this from happening again, any future fixes for this issue should include tests.

from permalinks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.