Comments (3)
@petasittek ,
As I've read https://nodejs.org/api/timers.html#timers_setimmediate_callback_args, this takes done callback to the end of the event loop. I'm not sure, but may be it should be placed after all plugin manipulations.
from permalinks.
Someone should look into using done()
directly instead of setImmediate()
from permalinks.
Logrocket has a good article about this: https://blog.logrocket.com/node-js-multithreading-worker-threads-why-they-matter/ (title: The naive solution: Synchronous code-splitting). The article admits "it’s hard to know where to put the setImmediate() to find a good balance.. In the context of this plugin, changing setImmediate(done)
to just done()
at the end would be clearer and very likely make no difference
from permalinks.
Related Issues (20)
- Add coverage
- Replace substitute package HOT 1
- unique option output (both default & custom) are hard to control. HOT 1
- Default linkset options overwrite further linksets
- Org migration alignment
- Get rid of unmaintained substitute dependency
- Generate an SEO inner link when we don't need it HOT 2
- Provide dual ESM/CJS build
- permalinks 3.0.0 roadmap
- Replace momentjs with alternative HOT 1
- Deprecate (and remove?) the "relative" option
- Using date in linksets throwing an exception HOT 2
- options unique & duplicatesFail overlap in functionality
- v2.5.0 broke the `slug` option HOT 7
- `path` or `permalink` not added to file’s metadata HOT 4
- `path` or `permalink` not added to file’s metadata HOT 2
- Bug: :dirname placeholders should not be slugified HOT 2
- enhancement: change how boolean values are processed (and test arrays) HOT 1
- Enhancement? Allow / in resolved placeholders through slugify
- Migrating from v2 to v3 -> maintain relative links HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from permalinks.