Code Monkey home page Code Monkey logo

Comments (4)

meowjesty avatar meowjesty commented on September 6, 2024

Why do we clear the env vars we get from vscode (extension entry-point)?

let mirrordApi = new MirrordAPI(cliPath);
config.env ||= {};
let target = null;

From what I'm getting, you can't set mirrord with env vars in the extension, it has to be set up with a config file.

So the goal here is to make this possible? Set up mirrord completely from env vars in launch.json, and pass this env var config through the usual flow? First checking if it's valid (verify-config), then allowing user to select target, and so on?

from mirrord-vscode.

aviramha avatar aviramha commented on September 6, 2024

It's not clearing, it's initializing if it's not initialized
if config.env is null -> config.env = {} else do nothing

from mirrord-vscode.

aviramha avatar aviramha commented on September 6, 2024

The goal is to pass "config.env" in the verify-config exec and in the mirrord ext exec to the configuration won't drift between executions.

from mirrord-vscode.

meowjesty avatar meowjesty commented on September 6, 2024

The env vars from launch.json are now being passed down to mirrord.

from mirrord-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.