Code Monkey home page Code Monkey logo

Comments (10)

dhellmann avatar dhellmann commented on September 7, 2024

cc @juliakreger @dtantsur

from baremetal-operator.

juliakreger avatar juliakreger commented on September 7, 2024

if translated directly to ironic's image_checksum it is assumed to be md5. Two different fields are used for other checksums: 'image_os_hash_algo' and 'image_os_hash_value'. FWIW, it requires a stein IPA ramdisk. The URL support, @dtantsur might be best to doublecheck because I think it has more support, but I don't remember offhand.

from baremetal-operator.

hardys avatar hardys commented on September 7, 2024

It would be nice to revive this as in combination with https://storyboard.openstack.org/#!/story/2006936 we could deploy the OKD images directly (they are shipped as xz compressed qcow2 images, with an sha256sum)

I think specifying the type of checksum in the existing field e.g sha256:xxxx seems reasonable and keeps the interface terse but still flexible - any objections to that approach?

We could retain the existing behavior by default by assuming md5 when no prefix is given?

@dtantsur can you confirm if image_os_hash_value works with the URL support we now rely on?

from baremetal-operator.

kirankt avatar kirankt commented on September 7, 2024

Hi, I have a question. Is the plan to still keep "image_checsum" in addition to a combo of "image_os_hash_algo:image_os_hash_value" or completely replace "image_checksum" with the latter?

from baremetal-operator.

hardys avatar hardys commented on September 7, 2024

Hi, I have a question. Is the plan to still keep "image_checsum" in addition to a combo of "image_os_hash_algo:image_os_hash_value" or completely replace "image_checksum" with the latter?

Perhaps @juliakreger can answer that, but I'd assume we continue using the existing interface for md5 checksums (e.g the default case) unless we're advised otherwise.

from baremetal-operator.

metal3-io-bot avatar metal3-io-bot commented on September 7, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from baremetal-operator.

kirankt avatar kirankt commented on September 7, 2024

/remove-lifecycle stale

from baremetal-operator.

kirankt avatar kirankt commented on September 7, 2024

Fixed in #401
/close.

from baremetal-operator.

maelk avatar maelk commented on September 7, 2024

/close

from baremetal-operator.

metal3-io-bot avatar metal3-io-bot commented on September 7, 2024

@maelk: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from baremetal-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.