Download link on QB throwing an error about metabase HOT 8 CLOSED

@salsakran do you have the original url you were looking at that this came from?

from metabase.

I think I already mentioned this in the e-mail, but of course it doesn't work. Look at the Query:

{
  "database": 7,
  "type": "query",
  "query": {
    "source_table": 269,
    "aggregation": [
      "rows"
    ],
    "breakout": [

    ],
    "filter": [
      "AND",
      [
        "=",
        2073,
        1
      ],
      [
        null,
        2075,
        null
      ]
    ]
  }
}

The stuff I merged into today should give a more useful error message but the fundamental problem here is that the user got a bad download link somehow. The fact that the bad link throws an error is expected behavior 👍

from metabase.

got it. i'm not sure i see what's wrong with the query though. is it because the breakout clause is empty?

from metabase.

No, the second filter subclause is seriously broken. There's no operator (= / != / etc) (pun intended) and the value is null too

from metabase.

The QX will remove empty clauses but throw an exception on invalid ones

from metabase.

sure. that makes sense. i'll close this as not a bug then. it's possible there is a frontend bug that is allowing queries to be run with half complete clauses, but we can file that separately.

from metabase.

This was a result of the Timestamp bug Tom fixed earlier this week.

The query builder would try produce broken query dictionaries, and the live
download link would result in that error dictionary.

I'd like to either reopen this bug or create another one to return a useful
error message instead of a json blob with a stack trace in the event of a
bad query dictionary (this goes for any link a user can click on the UI).
Even a 500 page would be better and would at least get logged. Not high
priority, but something to clean up when needing a break from bigger
hairier tasks.

On Thursday, July 9, 2015, Allen Gilliland [email protected] wrote:

Closed #561 #561.

—
Reply to this email directly or view it on GitHub
#561 (comment).

from metabase.

filed 2 separate issues to ensure this is fixed long term #569 and #570

from metabase.