Comments (4)
Which version of Visual Studio is this? Because the last time I tested this on VS2010 (the only version I have) it worked without needing to include the object file.
from meson.
I checked and VS2010 definitely does not require that you link in the object file. It does not harm either, so I changed it to always add it in. Can you test whether current trunk works for you?
from meson.
Yeah, it works for me now. The cpp pch sample which previously failed to compile also works now but I get the warning:
ninja
[1/3] Precompiling header ..\src\pch/prog_pch.cc
C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\xlocale(337) : wa
rning C4530: C++ exception handler used, but unwind semantics are not enabled. S
pecify /EHsc
[3/3] Linking target prog.exe
So I would suggest to add /EHsc by default.
By the way, meson generates the sanitycheck*.obj outside the build directory. It would be cleaner to put that file in the build directory or delete it.
from meson.
Thanks for testing. I fixed the sanitycheck one just now.
As far as /EHsc goes, it seems to me that people might want to compile with different exception types so putting that in by default does not seem right (as you can't unset the core flags set by Meson). Adding this in by yourself is a one-liner (or three lines if you want to wrap it in an if clause):
add_global_arguments('/EHsc', language : 'cpp')
I'm closing this issue as fixed now. If you have more to say about the exception argument, please open a new issue.
Thanks,
from meson.
Related Issues (20)
- subprojects ignore `shared_module`'s `build_by_default : false` option when `install : true` and build regardless
- Built-in `clang-tidy` target does not build pch files required to build the sources HOT 2
- Make it possible to refer to the compilation database directly HOT 4
- 'rewrite kwargs set dependency' results in an unhandled Python exception
- Accessing a meson subproject with the cmake module throws exception.
- minsize buildtype HOT 1
- format subcommand inconsistently indents comments HOT 1
- BUG: Slightly confusing `symbols_have_underscore_prefix()`
- format subcommand `kwargs_force_multiline` option allows kwargs to exceed `max_line_length` HOT 1
- OpenMP flag for IntelLLVM C/C++, icx/icpx, should be `-qopenmp` HOT 1
- Fix UnicodeEncodeError in AIX due to recent commit. HOT 2
- [Bug] CMake: Subdirectories may introduce file conflicts HOT 1
- meson-python-native-file.ini' failed to parse as unicode: 'utf-8' codec can't decode byte 0xdd in position 33: invalid continuation byte HOT 8
- check_functions is not correct HOT 2
- Handling meson project setup with name "meson" more gracefully. HOT 6
- ValueError: '...\\compiler\\subprojects\\antlr4-runtime\\runtime\\src' is not in the subpath of '...\\compiler\\subprojects\\subprojects\\antlr4-runtime' HOT 1
- Meson build for pandas errors with status 3221225477 HOT 3
- Meson doesn't respect OBJC
- mpv won't start with `meson install -C build` command
- [TAP] Bail out interpreted as SKIP if test plan and test line has not been printed yet
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meson.