Code Monkey home page Code Monkey logo

Comments (6)

Mesabloo avatar Mesabloo commented on June 7, 2024 1

@mateiadrielrafael I managed to reproduce your error completely, with the new enhancements from your suggestions.
This looks like this:
image

All the bugs should have been fixed, and your suggestions have also been implemented : there is now a vertical ellipsis when line numbers are not consecutive -- I am quite unsure if this fits well or not --, and multiline markers are output at the end of the line they stop on.

I think this looks way better now, thanks to your suggestions!

from diagnose.

Mesabloo avatar Mesabloo commented on June 7, 2024 1

The fixes have been published in the version 1.8.2.
Thanks again for the report and the cool suggestions!

from diagnose.

Mesabloo avatar Mesabloo commented on June 7, 2024

Thanks for the report!

The non-connection issue may be caused by a behavior I did actually not think about, where a multiline marker does not end at the last line of the report.
This may be mitigated by your suggestion number 2, which, now that I think about it, is far better than the current design.
I also like your suggestion of putting (with an empty line) when multiple ranges of code are not next to each other in the same report.

The issue 1 is however most probably a case I did not handled when coloring source code (when a multiline marker goes over the entire line without beginning/ending on it).
This should be a simple fix, I think. (inline markers need to be prioritized over multiline markers though)

from diagnose.

prescientmoon avatar prescientmoon commented on June 7, 2024

That's super cool! Thanks a lot.

If you don't mind me asking - what color scheme and font do you use? :)

from diagnose.

prescientmoon avatar prescientmoon commented on June 7, 2024

Also, I didn't mean 3 consecutive dots exactly, the more spaced out dots you already used to have are perfectly fine!

from diagnose.

Mesabloo avatar Mesabloo commented on June 7, 2024

This indeed looks better with single dots. I didn't quite like the ellipsis (it did not align well, and the ASCII equivalent looked horrible):
image

If you don't mind me asking - what color scheme and font do you use? :)

I am using the colorscheme Nord (the dark variant) and the font Iosevka Nerd. 🙂
I really like Nord and based my whole desktop theme on it!

from diagnose.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.