Comments (6)
@mateiadrielrafael I managed to reproduce your error completely, with the new enhancements from your suggestions.
This looks like this:
All the bugs should have been fixed, and your suggestions have also been implemented : there is now a vertical ellipsis when line numbers are not consecutive -- I am quite unsure if this fits well or not --, and multiline markers are output at the end of the line they stop on.
I think this looks way better now, thanks to your suggestions!
from diagnose.
The fixes have been published in the version 1.8.2
.
Thanks again for the report and the cool suggestions!
from diagnose.
Thanks for the report!
The non-connection issue may be caused by a behavior I did actually not think about, where a multiline marker does not end at the last line of the report.
This may be mitigated by your suggestion number 2, which, now that I think about it, is far better than the current design.
I also like your suggestion of putting ⋮
(with an empty line) when multiple ranges of code are not next to each other in the same report.
The issue 1 is however most probably a case I did not handled when coloring source code (when a multiline marker goes over the entire line without beginning/ending on it).
This should be a simple fix, I think. (inline markers need to be prioritized over multiline markers though)
from diagnose.
That's super cool! Thanks a lot.
If you don't mind me asking - what color scheme and font do you use? :)
from diagnose.
Also, I didn't mean 3 consecutive dots exactly, the more spaced out dots you already used to have are perfectly fine!
from diagnose.
This indeed looks better with single dots. I didn't quite like the ellipsis (it did not align well, and the ASCII equivalent looked horrible):
If you don't mind me asking - what color scheme and font do you use? :)
I am using the colorscheme Nord (the dark variant) and the font Iosevka Nerd. 🙂
I really like Nord and based my whole desktop theme on it!
from diagnose.
Related Issues (14)
- What do columns in `Position` mean? HOT 7
- [Bug] Duplicated markers with Error.Diagnose.Compat.Parsec HOT 2
- Relax bounds to allow text-2.0 HOT 3
- Consider exporting `prettyDiagnostic` HOT 8
- Unexpected addReport ordering HOT 1
- Integration with LSP? HOT 4
- Alternative `codespan-reporting` style formatting? HOT 58
- Issues for windows users due to dependency on wcwidth HOT 5
- How to deal with big content HOT 7
- Support Aeson 2
- Consider bumping dependencies / GHC version HOT 2
- Incorrect bounds for prettyprinter-ansi-terminal HOT 2
- Incorrect bounds for unordered-containers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diagnose.