Code Monkey home page Code Monkey logo

Comments (11)

rmkonnur avatar rmkonnur commented on August 12, 2024 1

You can expect a fix by EoD today. Will update in this thread when its pushed out.

from merge-python-client.

hwuiwon avatar hwuiwon commented on August 12, 2024 1

@dsinghvi

You should change the type to typing.Optional[typing.List[typing.Dict[str, typing.Any]]]

If it's okay, I'll fork it and open a new PR addressing this issue

from merge-python-client.

dsinghvi avatar dsinghvi commented on August 12, 2024 1

Got it -- that makes sense, the root cause is that the OpenAPI spec is incorrectly representing the API. So @rmkonnur is planning to fix the OpenAPI generation which will then regenerate a proper client library.

from merge-python-client.

dsinghvi avatar dsinghvi commented on August 12, 2024

@rmkonnur

permissions: typing.List[str] = pydantic.Field(
description="The Permission object is used to represent a user's or group's access to a File or Folder. Permissions are unexpanded by default. Use the query param `expand=permissions` to see more details under `GET /files`."
)
it looks like permissions should be typed str | List[str] in the OpenAPI spec

from merge-python-client.

hwuiwon avatar hwuiwon commented on August 12, 2024

When can I expect the fix?

from merge-python-client.

hwuiwon avatar hwuiwon commented on August 12, 2024

Should I create our own version of merge client that sends request directly to the API endpoint? I personally believe that not able to list files is a P1 issue and should be fixed ASAP. This has been blocking the service for few days now.

from merge-python-client.

dsinghvi avatar dsinghvi commented on August 12, 2024

@hwuiwon one option to unblock yourself is to make this change to the library locally (#39). Can you make that change and confirm that the SDK works end-to-end?

Apologize for any inconvenience.

from merge-python-client.

hwuiwon avatar hwuiwon commented on August 12, 2024

@dsinghvi I just tried and that would yield a different error.

12 validation errors for ParsingModel[PaginatedFileList]
__root__ -> results -> 0 -> permissions
  str type expected (type=type_error.str)
__root__ -> results -> 0 -> permissions -> 0
  str type expected (type=type_error.str)
__root__ -> results -> 1 -> permissions
  str type expected (type=type_error.str)
__root__ -> results -> 1 -> permissions -> 0
  str type expected (type=type_error.str)
__root__ -> results -> 2 -> permissions
  str type expected (type=type_error.str)
__root__ -> results -> 2 -> permissions -> 0
  str type expected (type=type_error.str)
__root__ -> results -> 3 -> permissions
  str type expected (type=type_error.str)
__root__ -> results -> 3 -> permissions -> 0
  str type expected (type=type_error.str)
__root__ -> results -> 4 -> permissions
  str type expected (type=type_error.str)
__root__ -> results -> 4 -> permissions -> 0
  str type expected (type=type_error.str)
__root__ -> results -> 5 -> permissions
  str type expected (type=type_error.str)
__root__ -> results -> 5 -> permissions -> 0
  str type expected (type=type_error.str)

from merge-python-client.

dsinghvi avatar dsinghvi commented on August 12, 2024

@hwuiwon any chance you are around for 15 min to hop on a zoom? You can join the fern discord and we can chat more realtime there.

from merge-python-client.

lucasgadams avatar lucasgadams commented on August 12, 2024

Im encountering this problem. It seems that previously the permissions field was a list of (str) ids, like:

  "permissions": [
    "1496fd39-1b31-42be-9aa4",
    "99b321d0-5dad-4268-b73c",
    ]

But now the permission object looks like:
image

So i guess just changing the type to str | JSON would fix the library.. but its a kind of breaking change

from merge-python-client.

rmkonnur avatar rmkonnur commented on August 12, 2024

Hi @hwuiwon, I pushed an update of the File Storage OpenAPI spec to generate the SDK this morning. Please try it out to confirm it fixes your issue. Apologies in the delay here - feel free to escalate via Intercom in the bottom right hand corner of the Merge dashboard for higher priority issues.
Thanks

from merge-python-client.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.