Comments (4)
Great, would you be up to implementing that behavior in your PR? @LuisFF
from deepbgc.
Hi @LuisFF, thanks for reporting this. I'll need to think for a bit since it's been a while since I wrote the code :)
I would be careful around changing the logic of get_proteins_by_id
, it's used in multiple places and not sure if it's safe to be able to only access the feature using its first protein ID, as proposed in your PR. Currently, it allows mapping from any of the potential protein IDs.
If I understand it correctly, this could also be solved by removing the protein_id
qualifier when entering the unique_protein_id
, correct? Here:
Lines 503 to 505 in c836f08
from deepbgc.
Hi @prihoda, thanks for looking into this.
Yes, removing the protein_id
qualifier from subsequent CDS
features with that same qualifier value is another way of solving this issue. That avoids any side effects I may overlooked in #79.
from deepbgc.
Hi @prihoda , I pushed the suggested changes.
Please let me know if there's anything else needed.
from deepbgc.
Related Issues (20)
- DeepBGC failed with ValueError: Grouper for 'sequence_id' not 1-dimensional
- Visualization HOT 1
- run Deepbgc in fungal genomes HOT 1
- WARNING: Tensor flow backened message when running deepbgc info into the CLI HOT 1
- how to get a cluster?
- installation error HOT 1
- how to create negative samples? HOT 1
- fit_generator
- what "inhibitor" means???
- Could deepBGC be used for special gene clusters?
- Hmmer and Prodigal Package Access Problem HOT 1
- Bugs for protein input HOT 1
- running "deepbgc info" issue
- Use https instead of ftp protocol for Pfam database download HOT 1
- Looking for individual genes
- ImportError: Missing required dependencies ['numpy'] HOT 1
- User Warning
- deepbgc info crash - same as Issue #39
- ValueError: End location (8780) must be greater than or equal to start location (9428)
- installing deepbgc HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deepbgc.