Hi-res timestamps causes failures about rtl_433_tests HOT 7 CLOSED

Actually the makefile will run

python bin/run_test.py -I time --first-line

thus ignoring the time stamps ;)

from rtl_433_tests.

That makes even more errors. py -2 bin\run_test.py -c ..\rtl_433.exe -I time --first-line acuri*:

## Failed: F:\gv\dx-radio\RTL_433\rtl_433_tests\tests\acurite\08\ext-lowbattery.cu8: invalid json output
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
## Failed: F:\gv\dx-radio\RTL_433\rtl_433_tests\tests\acurite\08\ext-lowbattery.cu8: invalid json output
time      : @0.044108s

But adding a -c NUL (or -c /dev/null for non-Windows) to the args, makes it perfect.

Thanks for clearing that up.

from rtl_433_tests.

If you have default config files for rtl_433 installed that might indeed mess with the tests script.
A short form to disable config files is -c 0.

from rtl_433_tests.

default config? I cooked one from rtl_433.conf.example.

But the run_test.py is so obfuscated, I fail to understand how it finds the files for testing. Besides many tests crashes. E.g. ..\rtl_433.exe -F json -s 250000 -r tests\acurite_3in1\g007_433.92M_250k.cu8
crashes inside print_kv_data(). Another PR ?

from rtl_433_tests.

I meant a config at the default location, i.e. loaded by default.
No crash with that line here, perhaps you can trace where the fault is? Or even better PR a fix :)

from rtl_433_tests.

I meant a config at the default location, i.e. loaded by default.

Is there a single default location? AFAICS it tries to load rtl_433.conf from several places. I have only 1 where rtl_433.exe is.

The crash was easy though. term_get_columns() returned gibberish when used from Python's Popen(). Hence:

--- a/src/term_ctl.c 2018-12-22 13:39:06
+++ b/src/term_ctl.c 2018-12-28 10:45:24
@@ -169,7 +169,9 @@
     if (!console->hnd || console->hnd == INVALID_HANDLE_VALUE)
        return (80);

-    GetConsoleScreenBufferInfo(console->hnd, &c_info);
+    if (!GetConsoleScreenBufferInfo(console->hnd, &c_info))
+       return (80);
+

from rtl_433_tests.

The paths on Windows are here: https://github.com/merbanan/rtl_433/blob/master/src/compat_paths.c#L40
Thanks for the fix, patched with merbanan/rtl_433@e843853

from rtl_433_tests.