Code Monkey home page Code Monkey logo

Comments (7)

Mimisor7 avatar Mimisor7 commented on May 28, 2024

I didn't read the instructions for the new version! I thought they stayed the same...

from godot-psx-style-demo.

Mimisor7 avatar Mimisor7 commented on May 28, 2024

Closing issue

from godot-psx-style-demo.

Mimisor7 avatar Mimisor7 commented on May 28, 2024

Actually, meshes still appear invisible for me for some reason, even if the shader parameters work again after adding the precision_multiplier float in shader globals. I'm gonna open a seperate issue for that if I can't get meshes to display properly with these shaders within the next 48 hours

from godot-psx-style-demo.

Mimisor7 avatar Mimisor7 commented on May 28, 2024

actually I might've found the problem already... I'm gonna open a seperate issue for this
image

from godot-psx-style-demo.

MenacingMecha avatar MenacingMecha commented on May 28, 2024

Hi, please don't open multiple issues for the same issue unless they really are the same issue. In this case, they're not, the issue is "I can't get them to work in a new project", so I'll close #17 as a duplicate.

I was not able to recreate the issue either in the demo project, or a new project by copying the shaders. I will say, however, I had to close and re-open the scene for the shader to read the updated global shader parameters, which might've been your issue.

Example minimal reproduction project: psx-issue-16-test.zip

Unless this issue persists, I'm happy to close this.

from godot-psx-style-demo.

Mimisor7 avatar Mimisor7 commented on May 28, 2024

I found the reason why this hasn't been working for me...
Upon comparing your project (that actually works) to mine, I found that I should've set the precision_multiplier's float value to 1.
I had it on 0 for my project, because Godot by default sets the value to 0 when you create a float.
You should probably update the instructions to say that you should set the precision_multiplier's value to 1 after creating the float in your existing project's shaderglobals so that this problem doesn't happen to anyone else again.

from godot-psx-style-demo.

MenacingMecha avatar MenacingMecha commented on May 28, 2024

91bd249

from godot-psx-style-demo.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.