TenantTokenOptions in wrong location (or package) about meilisearch-java HOT 4 CLOSED

No problem @curquiza - happy to help. Let me know if you need anything else from me on this 🙂

from meilisearch-java.

Hello @jrhenderson1988
thanks for the report

I'm not sure to understand how your fix cannot be breaking for the users (I'm not an expert in Java). Can you explain a little bit? Or maybe I would better understand with the open PR...?

from meilisearch-java.

Hey @curquiza

I wouldn't expect the fix to be breaking, because existing consumers of the API would be importing that particular class using its package name (rather than the path as it is defined in the filesystem), like this:

import com.meilisearch.sdk.TenantTokenOptions;
// ...
TenantTokenOptions tto = new TenantTokenOptions();

My suggested fix would not change the package name of that particular class. It would instead just move the file up one directory so that the package name matches the file path. No content would be changed.

Since the declared package would not be changed, existing consumers of the API would still be importing from the same place.

I'll create a pull request to demonstrate the change.

from meilisearch-java.

Thank you @jrhenderson1988 for the explanation!
Looking at your PR in the coming week

from meilisearch-java.