Code Monkey home page Code Monkey logo

Comments (13)

maldworth avatar maldworth commented on July 17, 2024

👍 for a fork + pull request and a nuget package!

from dbcontextscope.

tiesont avatar tiesont commented on July 17, 2024

@maldworth If you're interested in being a bit of a test subject, you can try the NuGet package I've uploaded here: https://drive.google.com/open?id=0By4iYTLNHcYRMVJ2SG9xSlMxVWM&authuser=0

Extract the 7zip archive. You'll have to create a local NuGet source, and then you can add this package to a project. Everything was moved to a Mehdime.Entity namespace, but other than that no code changes, so it should just work.

from dbcontextscope.

maldworth avatar maldworth commented on July 17, 2024

@tiesont I just tried it and the nupkg and it works great. I'm curious if the Interfaces should be either broken into a separate namespace, or a separate package. I like to separate my contracts from implementation. What is the standard nuget packaging guidelines for implementation and contract separation?

from dbcontextscope.

tiesont avatar tiesont commented on July 17, 2024

@maldworth I don't recall that there are NuGet guidelines for namespaces. I can see separating the interfaces into a separate namespace, but what is gained by doing so? The current codebase actually does this, but also keeps them in separate assemblies. I didn't want to deploy them like that as a NuGet package, so I combined them.

I take the stance that assemblies like System.Web, et al, don't separate namespaces or assemblies at that level; you can organize classes and whatnot into folders within the solution & project, but namespaces don't need to reflect that.

from dbcontextscope.

maldworth avatar maldworth commented on July 17, 2024

@tiesont Yeah, Nothing is gained in this scenario. I'm good with the package as you provided. Let me know when you upload it to Nuget.org!

from dbcontextscope.

tiesont avatar tiesont commented on July 17, 2024

@maldworth Uploaded to https://www.nuget.org/packages/Mehdime.Entity/ - let me know if you have any issues with the "live" package.

from dbcontextscope.

ChrisMarinos avatar ChrisMarinos commented on July 17, 2024

Can you submit a pull request for this work? It's pretty confusing that the nuget package doesn't match the repository.

from dbcontextscope.

tiesont avatar tiesont commented on July 17, 2024

@ChrisMarinos I suppose I should. I'll see if I can get around to it at some point.

It's worth pointing out that @mehdime never gave a "yay/nay" response to this suggestion. I went ahead and published the NuGet package with my version mostly because it's what I had handy, and I don't like pushing multiple assemblies in one package if I can avoid it.

from dbcontextscope.

ChrisMarinos avatar ChrisMarinos commented on July 17, 2024

Yeah, that makes sense. PR or not, it would just be good to have the code that you used to publish the package somewhere on github.

from dbcontextscope.

tiesont avatar tiesont commented on July 17, 2024

@ChrisMarinos Pushed code to my fork, and pull request created. We'll see what @mehdime says.

from dbcontextscope.

mehdime avatar mehdime commented on July 17, 2024

Hi guys,

Pull request merged. And apologies for the silence in the last while - I'll try to address all open issues in the next week. I should have a little bit of free time then.

Thanks a lot!

from dbcontextscope.

tiesont avatar tiesont commented on July 17, 2024

@mehdime Awesome. Did I ever ask if you have a NuGet account? I'd like to add you to the package as an owner. My contact info is public on my profile, if you can send me a quick email.

from dbcontextscope.

mehdime avatar mehdime commented on July 17, 2024

Sent email.

from dbcontextscope.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.