Code Monkey home page Code Monkey logo

Comments (21)

norricorp avatar norricorp commented on June 2, 2024 5

Working with svelte 4 would be very useful. Last commit was 8 months ago.
Is the project still active?

from svelte-navigator.

norricorp avatar norricorp commented on June 2, 2024 3

I have forked the project (norricorp/svelte4-navigator), downloaded it and made changes. It compiles and I have used it in my project (which is also upgraded to svelte 4) and it all appears to work.
I have no pushed the changes yet.
So after the changes have been pushed, I open a PR to go from norricorp/svelte4-navigator to mefechoel/svelte-navigator?
But that depends if mefechoel is still updating it.
Is there a test suite I can run against my change?

from svelte-navigator.

ignatij avatar ignatij commented on June 2, 2024 2

Any progress here on this issue? We struggle with the same problem

from svelte-navigator.

norricorp avatar norricorp commented on June 2, 2024 2

That was the conclusion I came to as well.
Just to add that restructuring for sveltekit is a lot of work and it did make me realise how convienient svelte-navigator is so a great shame that it is no more.

from svelte-navigator.

norricorp avatar norricorp commented on June 2, 2024 1

I have commited to the forked repo and created a pull request to the part repo.
I guess it is up to mefechoel now?

from svelte-navigator.

mefechoel avatar mefechoel commented on June 2, 2024 1

Hello there ans thanks for the pr! Unfortunately i don't have a lot of time to work on the project, but i'll try to review your pr soon. There are quite extensive tests, you can run using the npm test command. I'll also run them in the github actions pipeline of you pr, so you'll see the results there too.

from svelte-navigator.

pndiogo avatar pndiogo commented on June 2, 2024 1

While SvelteKit seems to be the more future proof approach, svelte-navigator is just a nice library to implement on an existing Svelte project. Is there any perpective of updating it's Svelte dependency to version 4?

from svelte-navigator.

MrBns avatar MrBns commented on June 2, 2024 1

I think this project is died. owner should archive this repo so that everyone can understand.

from svelte-navigator.

flpms avatar flpms commented on June 2, 2024 1

I already fork the project and try to learn more about it. anyone here already tried the project that's was forked?

https://github.com/EmilTholin/svelte-routing

This project seems continue be maintained

from svelte-navigator.

flpms avatar flpms commented on June 2, 2024

That's a good question, I already schedule a change to sveltekit after see this issue.

Be sides exists the roadmap #19

from svelte-navigator.

Visual-Dawg avatar Visual-Dawg commented on June 2, 2024

Hey guys, which other libraries for routing can you recommend?

from svelte-navigator.

Foorack avatar Foorack commented on June 2, 2024

from svelte-navigator.

norricorp avatar norricorp commented on June 2, 2024

I agree that svelte kit is the answer but I would like to get svelte navigator working with svelte 4 just because ....

from svelte-navigator.

kevin4dhd avatar kevin4dhd commented on June 2, 2024

any solution?

from svelte-navigator.

norricorp avatar norricorp commented on June 2, 2024

Unfortunately not.
I think override is the short term answer and sveltekit is the long term answer.
With regard to testing, the test app definitely behaves differently in the svelte 3 and 4 versions, with chunks of code not called in history.js. It may possibly the test app that is the problem.

from svelte-navigator.

norricorp avatar norricorp commented on June 2, 2024

Hi @pndiogo,
basically I am stuck so any help would be great.
I have run the svelte 4 migration (which updated svelteinternal.d.ts) and package.json. The changes pass unit tests and it works fine in my app. But the integration tests fail.
I have added console.logging to both my changes and the original svelte3 code and can see where functions are not called in the former but no idea why this is happening. Could even be the test app.

I completely agree with your comment that svelte-navigator is just easier to use for an existing project. Certainly moving to sveltekit is a lot of work.

If you would like to discuss further than am more than happy to email you directly.

from svelte-navigator.

sushidub avatar sushidub commented on June 2, 2024

UPDATE:
Nevermind, I see in your commit you've just updated the dependencies list which I can do myself locally. Good luck on the testing.


@norricorp

I think override is the short term answer ...

I realize your fork and PR solves this issue and your now just waiting on help from the current maintainer to get the integration tests to pass. In theory tho, is it possible to go ahead and use your override for those of us that don't want to wait on the PR merge (assuming our own risk of course). If so, do you have a commit hash you would recommend using with just the override and not all the testing mumble jumble?

from svelte-navigator.

abrman avatar abrman commented on June 2, 2024

I used npm install svelte-navigator --force seems to work also, but you'll never feel clean again.

from svelte-navigator.

dysfunc avatar dysfunc commented on June 2, 2024

This is what I'm using in our production app:

"overrides": {
  "svelte-navigator": {
    "svelte": ">=4.x"
  }
}

I've started working on a branch to migrate this package to Svelte 4+. It's partially done, but a decent amount to go.

from svelte-navigator.

marekdedic avatar marekdedic commented on June 2, 2024

Unfortunately, it seems that svelte-navigator may be abandoned. I am currently switching to SvelteKit (with adapter-static) due to this... :(

from svelte-navigator.

flpms avatar flpms commented on June 2, 2024

Did you consider use the original https://github.com/EmilTholin/svelte-routing? This project is a fork from svelte-routing, may it's more easy to migrate.

Sadly I didn't tried yet, but I'll pretty soon

Unfortunately, it seems that svelte-navigator may be abandoned. I am currently switching to SvelteKit (with adapter-static) due to this... :(

from svelte-navigator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.