Add language to the Fetch query endpoint about check HOT 8 CLOSED

As it is currently written, we have an endpoint that essentially does this already - GET /claim_reviews.json has the following structure:

      {
        method: 'GET',
        params: {
          query: 'string (default none)',
          service: 'string (default none)',
          start_time: "time-parseable string (e.g. '2020-01-01' or 'Sept 20 2019', default none)",
          end_time: "time-parseable string (e.g. '2020-01-01' or 'Sept 20 2019', default none)",
          per_page: 'integer (default 20)',
          offset: 'integer (default 0)'
        }
      }

Here, we can cursor through time using the two time parameters, specify a provider using the service option, and specify a query with query, which should work fine with any valid ES-type logic query in that spot. The only one not present in here is languageCode which I agree would likely be useful. If we do this, the only thing that needs to happen is adding this language field to the query.

from check.

Hey, @DGaffney can you help me how to proceed as you have mentioned, I am not able to find the file with the given code. I am new to open-source, so your help will be valuable.

Hi! Glad to have you here. The code that I'm referencing will mostly need to be added over in the fetch repository. Specifically, in the lib/elastic_search_query.rb file around line 108, a new conditional clause would need to be added that'd look something like:

    if opts[:language]
      query[:query][:bool][:filter] << ElasticSearchQuery.query_match_clause('language', opts[:language])
    end

This would also probably need a few new tests as well. Does this help clarify? Happy to discuss more!

from check.

Hey @infojunkie! Can I work on this issue?

from check.

Hey @infojunkie! Can I work on this issue?

Please!

from check.

Hey, @DGaffney can you help me how to proceed as you have mentioned, I am not able to find the file with the given code. I am new to open-source, so your help will be valuable.

from check.

I would need to add new tests in the fetch/spec/lib/elastic_search_query_test.rb and fetch/spec/models/claim_review_test.rb files I suppose. @DGaffney

from check.

meedan/fetch#64
meedan/fetch#65

from check.

Closed with meedan/fetch#64 and meedan/fetch#65

from check.