meatspaces / meatspace-chat-v2 Goto Github PK

I noticed today that a style request was made in a pr... this could be avoided / automated through the use of a linting task + CI (potentially travis).

If no one is opposed to this I will probably roll it out tonight / this weekend.

I was tabbed away from chat.meatspac.es for around 10-15 minutes earlier tonight and realized my computer was starting to get toasty like when v2 first launched. Coming back to the page, I had 80+ (I stopped counting, in retrospect i probably could have jqueryed it) videos in total on the page. Seemed like it was also really slowing my computer down as well. Refreshing the page, and returning to the default 15 messages, everything sped up again, and now I'm typing this with my laptop on an ottoman waiting for it to cool down. Perhaps if messages are going to be added to the DOM while the tab is not active, then old messages should be popped as well? Not sure if that was a conscious decision to allow people to 'catch up'.

PS Before I alt-tabbed away, i was scrolled up to the top of the page. I'm not sure if that makes a difference when attempting to repro this, or if that might effect the pause/unpause behavior when in a different tab, but seemed like it could be important.

Chrome Version 38.0.2125.104
Mac OSX 10.9.5

Filing or talking to appropriate browsers

Example: http://thewor.st/ gets linkified, but thewor.st does not. thewor.com behaves as expected.

Data URI weirdness on kitkat
https://code.google.com/p/chromium/issues/detail?id=419305

h.264 not displaying firefox
https://bugzilla.mozilla.org/show_bug.cgi?id=1075443

Breaks my buttmarklet and makes me a sad panda

new messages automagically scroll to the bottom. This breaks the ability to read scroll back and makes me a sad boi

The actual meat message text cannot be highlighted/selected, although the timestamp and mute text can. This apparently affects Chrome, but not Firefox.

socket.io supports binary websockets, and the native clients have caught up and also support them. this would save a ton of cpu and bandwidth since we don't need to b64 stuff anymore.

will send a PR when I have time

On mobile the ui forces left/right scrolling to be active. That's probably not ideal.

On Android (have not tested other OS's), The text does not scroll once you have overflowed the input box… so you can't see what you are writing.

/home/jose/meatspace-chat-v2/node_modules/meatspace-publico/node_modules/level/node_modules/leveldown/node_modules/bindings/bindings.js:83
throw e
^

Error: Module did not self-register.
at Error (native)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at bindings (/home/jose/meatspace-chat-v2/node_modules/meatspace-publico/node_modules/level/node_modules/leveldown/node_modules/bindings/bindings.js:76:44)
at Object. (/home/jose/meatspace-chat-v2/node_modules/meatspace-publico/node_modules/level/node_modules/leveldown/index.js:1:99)
at Module._compile (module.js:434:26)
at Object.Module._extensions..js (module.js:452:10)
at Module.load (module.js:355:32)

npm ERR! Linux 4.2.0-16-generic
npm ERR! argv "/home/jose/.nvm/versions/node/v4.0.0/bin/node" "/home/jose/.nvm/versions/node/v4.0.0/bin/npm" "start"
npm ERR! node v4.0.0
npm ERR! npm v3.8.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: node index.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script 'node index.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the meatspace-chat package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node index.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs meatspace-chat
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls meatspace-chat
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /home/jose/meatspace-chat-v2/npm-debug.log

for discussion.

to start, i think switching to blobs will decrease cpu usage. also when messages are off-screen we can deallocate the blob via revokeObjectURL

cc @tec27 @ednapiranha

Probably also applies to the standard version

crypto.js:209
  this._binding.update(data, encoding);
                ^
TypeError: Not a string or buffer
    at Hash.update (crypto.js:209:17)
    at getUserId (/web/MEAT/meatspace-chat-v2/index.js:77:39)
    at Socket.<anonymous> (/web/MEAT/meatspace-chat-v2/index.js:114:24)
    at Socket.emit (events.js:95:17)
    at Socket.onevent (/web/MEAT/meatspace-chat-v2/node_modules/socket.io/lib/socket.js:327:8)
    at Socket.onpacket (/web/MEAT/meatspace-chat-v2/node_modules/socket.io/lib/socket.js:287:12)
    at Client.ondecoded (/web/MEAT/meatspace-chat-v2/node_modules/socket.io/lib/client.js:185:14)
    at Decoder.Emitter.emit (/web/MEAT/meatspace-chat-v2/node_modules/socket.io/node_modules/socket.io-parser/node_modules/component-emitter/index.js:134:20)
    at Decoder.add (/web/MEAT/meatspace-chat-v2/node_modules/socket.io/node_modules/socket.io-parser/index.js:233:12)
    at Client.ondata (/web/MEAT/meatspace-chat-v2/node_modules/socket.io/lib/client.js:170:16)
30 Sep 18:06:23 - [nodemon] app crashed - waiting for file changes before starting...

A JavaScript error occurred in the main process
Uncaught Exception:
TypeError: Cannot read property 'on' of undefined
at Object. (/home/jose/electron-quick-start/main.js:34:4)
at Module._compile (module.js:425:26)
at Object.Module._extensions..js (module.js:432:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:313:12)
at loadApplicationPackage (/home/jose/electron-quick-start/node_modules/electron-prebuilt/dist/resources/default_app/main.js:257:23)
at Object. (/home/jose/electron-quick-start/node_modules/electron-prebuilt/dist/resources/default_app/main.js:289:5)
at Module._compile (module.js:425:26)
at Object.Module._extensions..js (module.js:432:10)
at Module.load (module.js:356:32)

Even after getting ffmpeg set up it isn't obvious how to make it available to meatspace

E.g. "it expects ffmpeg to be available via your $PATH"

Button to toggle camera off
Disable camera while in different tab

In order to make it easier to troubleshoot installations of meatspace it would be nice to have a simple test that ran through convert2video.js in the same way meatspace does.

cc @kid-icarus to implement

https://github.com/contra/hd.css

Not sure if it is intentional or an oversight. If it is intentional then you can just close this issue.

So I think some of the 'issues' that have been seen with links messages being truncated are due to the twitter link library being used before the message is truncated

https://github.com/meatspaces/meatspace-chat-v2/blob/master/lib/services.js#L70
Here the message gets auto-linked

https://github.com/meatspaces/meatspace-chat-v2/blob/master/lib/services.js#L74
aaaand here its sliced down to 250 characters, with all the extra HTML inserted.

So for instance I sent the message:
http://www.bigbadtoystore.com/bbts/product.aspx?product=OOC10000&mode=retail&utm_source=retail_news&utm_medium=email&utm_campaign=BigBadToyStore-Retail&utm_content= omg need this
Which is 178 characters, but my client got the message
<a href="http://www.bigbadtoystore.com/bbts/product.aspx?product=OOC10000&amp;amp;mode=retail&amp;amp;utm_source=retail_news&amp;amp;utm_medium=email&amp;amp;utm_campaign=BigBadToyStore-Retail&amp;amp;utm_content=" target="_blank" rel="nofollow">http aka 250 characters
Which chrome was nice and auto-closed for me with a tag. I imagine some other browsers are not doing this. and might be dropping the message entirely. If the link is more than 250 characters I'm willing to bet that it won't even display the link.

What's the ruling on this? Should the linkification be done AFTER the 250-character limit? Alternatively it could be done-client side, I believe that twitter does the linkification that way, so that the link text is part of the text, but the HTML-code is not. I'm trying to get a local version going to write a PR for the former.

The current repo linked is: https://github.com/meatspaces/meatspace-chat-v2/tree/no-glitch

But that leads to a 404. I assume it should be the following: https://github.com/meatspaces/meatspace-chat-v2

⬆️

It strips everything post second @.

@fritzvd introduced this over in MeatDroid but it would probably be useful to have it built-in to the site instead.

i.e. let the user dismiss the sad modal and just watch.

prebuild WARN install Failed to download prebuild
prebuild ERR! build Can't find Python executable "python", you can set the PYTHON env variable.
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\jose\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "i" "[email protected]" "--save"
npm ERR! node v5.5.0
npm ERR! npm v3.5.3
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: prebuild --download
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] install script 'prebuild --download'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the leveldown package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! prebuild --download
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs leveldown
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls leveldown
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! C:\Users\jose\meatspace-chat-v2\npm-debug.log
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok
[email protected] C:\Users\jose\meatspace-chat-v2
└── [email protected] extraneous

npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\jose\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v5.5.0
npm ERR! npm v3.5.3
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the leveldown package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs leveldown
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls leveldown
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! C:\Users\jose\meatspace-chat-v2\npm-debug.log

Hello

A Noob here.

I came across meatspsace and I think it's the coolest!

I cloned the repo and I am trying to get it running on my local machine.

I did the first four steps:

• install ffmpeg
• npm install
• cp local.json-dist local.json
• npm start

Now what? When I go to localhost:3000 I get nothing. No server is detected.

Does the node version matter? I am using the most recent version at the time of this post ( v0.10.35 ).

The cmd line shows no errors... it looks like this

> gulp & nodemon index.js

[14:49:16] Using gulpfile ~\Desktop\Meatspace\meatspace-chat\gulpfile.js
[14:49:16] Starting 'css'...
[14:49:16] Starting 'js'...
[14:49:16] Starting 'static'...
[14:49:16] Starting 'watch'...
[14:49:16] Finished 'watch' after 80 ms
[14:49:19] Finished 'css' after 3.4 s
[14:49:25] Finished 'static' after 9.4 s
[14:49:33] Finished 'js' after 17 s
[14:49:33] Starting 'default'...
[14:49:33] Finished 'default' after 18 µs

Thanks for your time!

Firefox is rejecting the current cert with:
Error code: sec_error_unknown_issuer

Node similarly won't connect, socket.io gives a connect_error with:
{ [Error: xhr poll error] description: 503 }

Chrome seems fine with it, and ssllabs doesn't really pick up on any problems, not sure why that is. Seems like the server is missing the necessary intermediate certs for this new cert?

I tried to post pages of my notebook today. Between a distance of around 1" - 6" on my MBP the preview box would count down but nothing would get put into the chat.

I tested this about 20 times with different books to find the range. It also seems that images of higher complexity (less whitespace?) seem to not get posted.

I'm not sure if this is a genuine issue or more of an edge case, but it is pretty curious to me. If someone at least knows why it could be happening, I'd be interested

*** This is also my first ever use of github. Apologies for any sort of etiquette breach. Thanks. :)

Currently there are no contribution guidelines. Eventually I would love to make a patched version of the ZeroMQ c4 as some aspects of the contract aren't agreeable for our purposes.

Until then, we need to set some basic guidelines, as I've witnessed code being directly pushed to master from contributors which is problematic in that it strips control of code-base from the community.

Hi, i installed succefully ffmpeg but i have this error:
error { [Error: Command failed: /bin/sh: 1: ffmpeg: not found
] killed: false, code: 127, signal: null }

Where i need put /bin/sh folder?

It would be super cool if we could support sending pre-encoded video. I need to think about demuxing out any audio in the container, but it seems like it makes sense to offload the encoding to clients that support it.

Google Chrome Version 37.0.2062.124

Message entered in text box:
maybe I can convince them to take me out to lunch to the grey dog and you guys can be complimenting me from a couple tables over "whoah that guy looks really smart & cool & would be a great asset as a developer at whatever company he decided to join"
Character count: 251

Displayed in the v2 client:
maybe I can convince them to take me out to lunch to the grey dog and you guys can be complimenting me from a couple tables over "whoah that guy looks really smart & cool & would be a great asset as a developer at whatever company he dec
Character count: 238

So you have to click on the input box every time you want to send a message. It is seriously hampering my ability to spam the hell out of the channel.

I think that we need to revise how scrollback works a bit so that people don't log into an empty channel quite so often.

Maybe just dropping the time limit so it is always the last 30 messages, or maybe increasing the time limit to an hour instead of 10 minutes. There may be other ways of dealing with the situation, and I would like to open up a discussion about it so that we can evaluate the options as a community.

When muting a user, a bug very similar to #52 occurs, and can cause 1 or more videos to pause. The videos can be restarted again by right clicking and selecting play.

Reproduced on Chrome 38.0.2125.104 in Windows and 37.0.2062.120 in ChromeOS

Firefox 34 is not recognized by Meatspaces as valid browser.

Definitely related to waypoints in some way, but if messages come in in quick succession (seemingly), the last couple messages (maybe more? maybe less?) don't get marked as being in view, or get marked as being in view and then marked as out of view, and so are paused until another message comes in.

I looked at the DOM in Chrome devtools when this occurred and definitely saw the last two videos, despite being visible, did not have the in-view class at the time.

I suspect this is something to do with the videos not being loaded when they're added to the DOM, although I have no real way to prove this easily. Further investigation needed!

I was just told that I need to use Chrome for meatspaces, while using Chrome Version 40.0.2214.115 m.

I'm running Iceweasel 38.0.1, which is a renamed version of Firefox distributed in Debian. Meatspace does not recognize this browser, although I strongly suspect it has all of the mechanisms in place for Meatspace to work.

I just visit the site on my android phone w/ chrome browser. I get that. I can post videos, but they don't show up for me (but they do on other browsers, so that part works).

The Collective Code Construction Contract is a contract that I think will benefit this project, as it gives very clear guidelines on how to contribute.

There are parts of the contract that are disagreeable for our purpose. Lets discuss this, patch the contract for our use, and see it instituted!