Comments (7)
@mearashadowfax appreciate those component changes! The only issue I'm seeing is with a missing src/images/placeholder.png
. Removing the import for this file shows the website correctly. Is it possible to add this file (ignoring all other images) without copyright concerns?
I also understand that local development testing isn't required. However, it's helpful to test locally to ensure a) the Markdown file is formatted correctly (YAML is frustrating at times) and b) the recipe renders how I expect. Helped me catch a few issues before I made my PR, like an unexpected NaN when I set "1 1/2" as an item quantity.
from openstove.
@bholmesdev Ah, that pesky .png
was hiding in the .gitignore
list! Fixed that, thanks for pointing it out!
Yes, local testing might not be mandatory, but you're absolutely right - it's super helpful to see and test everything locally. By the way, huge thanks for being the first one to add a recipe and providing such insightful feedback! Really appreciate it.
from openstove.
Ah for sure! Appreciate that @mearashadowfax. Remember seeing Open Stove on the showcase discussion a while back and bookmarked to send a recipe. I'll let other people know to see if we can drive some contribution :)
from openstove.
Hello @bholmesdev, thank you for pointing this out! I've just added the missing Meta.astro component to the project.
from openstove.
Hey thanks for fixing this @mearashadowfax! Unfortunately, I now see a missing image when building this repo locally: ../images/hero-image.svg
. In fact, I don't see a src/images/
directory looking at the source. Do you mind double checking that all resources are present and the production build succeeds? I would love to contribute a recipe and want to test my work.
from openstove.
Hey, @bholmesdev ! You're right, the src/images/
directory is currently excluded due to copyright restrictions on the images used, I'm afraid it is not possible to test locally. However, if you've followed the Recipe Format Guidelines
, there's nothing to worry about. We'd love to see your recipe contribution!
from openstove.
@bholmesdev, I've made some adjustments, now you should be able to see and test your recipes locally.
from openstove.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openstove.