New mapping for Mad Catz Fightpad SFxT about sdl_gamecontrollerdb HOT 12 CLOSED

Does this follow our template? https://github.com/gabomdq/SDL_GameControllerDB/blob/master/data/mapping_guide.png

from sdl_gamecontrollerdb.

The buttons placement is similar to the Sega one on your template (with LB and LT in addition, on the side of the controller, LT being treated as a button too) but I don't really understand your question or what this template is for. Here is a photo of the same model: https://media.ldlc.com/ld/products/00/01/03/55/LD0001035519_2.jpg

Since I first contributed the mapping and now, the buttons haven't changed, except that LT and RT, while implemented physically as buttons, were seen as axis by SDL at the time. Now they're seen as buttons and have taken the place of others in the order, so some have been "shifted". I just took the old line from the DB on GitHub and replaced the wrong values by the correct ones, if that's what you're asking.

from sdl_gamecontrollerdb.

What I'm asking is, do your changes follow the template. Are the 'Z' and 'C' buttons mapped to 'RB' and 'RT'? Please open a PR to discuss your change.

from sdl_gamecontrollerdb.

If we consider the Sega template (though it's not meant to be a Sega controller, it's a controller that is made for fighting games, so it has 6 buttons on the face instead of 4), yes, the buttons match, as you can see on the photo I've linked; I have the exact same model.

from sdl_gamecontrollerdb.

Perfect. We get a lot of strange controllers, so yes its just the general design of it that matters (gamepad with 6 buttons in 2 rows, aka sega controllers). Like I said, you need to open a PR so I can merge the change. Will close this issue. Ty.

from sdl_gamecontrollerdb.

What's a PR?

from sdl_gamecontrollerdb.

Pull request :)

from sdl_gamecontrollerdb.

Errr... sorry but I'm completely lost in GitHub. If I do a pull request, it asks me to compare branches (?). Do I choose to compare master and buttons, then leave a comment with the new mapping? When I compare these two, all the mappings in the db that appears show as empty (they have the list of buttons with nothing set).

from sdl_gamecontrollerdb.

It seems my reply didn't go through. Sorry for the delay.
You want to merge into our master SDL_GameControllerDB/master from your master terzag/master. Buttons is an old prototype branch.

Feel free to make mistakes, you can always close and reopen your pull request. If there are issues I will point them out. cheers

from sdl_gamecontrollerdb.

Oh, there might be a small misunderstanding there: I don't have a "clone" (or "fork", or whatever is the right term) of you repo, I just looked at your gamecontrollerdb.txt, copied the line (313) and opened the bug report with the new buttons values.

from sdl_gamecontrollerdb.

Well you will need to fork the repo if you want to send a PR to fix your issue.

from sdl_gamecontrollerdb.

Ok, I think I did it properly (?)

from sdl_gamecontrollerdb.