password should not be configured on command line about unifi_exporter HOT 8 CLOSED

Makes sense to me. I went with flags for ease of use but I can understand your point.

Should be easy enough to add something like -unifi.config.file ~/.config/unifiexporter.yml or something.

Would environment variables also be acceptable?

from unifi_exporter.

Having the password in an environment variable is a little better, but still problematic is that the environment variable might need to be initialized somewhere (like a systemd unit file) that is world readable. In a config file is the best option, until Ubiquity offers an alternative like OAuth.

from unifi_exporter.

Would you be fine with having an INI file (using https://github.com/go-ini/ini)? If yes, then I would take a shot at creating a PR.

from unifi_exporter.

Funny you should post that @mbrgm - I've just finished creating support for a yaml configuration file and am about to submit a PR. I've never worked on Go before but it works and it's relatively tidy, so feel free to critique it.

from unifi_exporter.

@mtanatwine See my comments. I took the 'critique' part seriously, but everything I mentioned is very pedantic. Just thought I'd take the time to go through it thoroughly. Thanks! :)

from unifi_exporter.

spf13/viper is a good drop-in option for managing config files with command-line and/or environment overrides (although it's far from drop-in, tbh).

from unifi_exporter.

@dichro That's right, but I think for this project it might be overkill. @mtanatwine 's PR does the job fine imho.

from unifi_exporter.

I think this can be closed, now that #37 has been merged, right?

from unifi_exporter.