Code Monkey home page Code Monkey logo

Comments (7)

mProjectsCode avatar mProjectsCode commented on July 18, 2024 2

my bad, the first entry in the stack trace is actually this plugin. It seems like the is a missing null check on this line https://github.com/mdelobelle/obsidian_supercharged_links/blob/c549bc7c74c24b71baaa0b156751012580757a31/src/linkAttributes/livePreview.ts#L29C18-L29C18

from obsidian_supercharged_links.

mProjectsCode avatar mProjectsCode commented on July 18, 2024 1

Or maybe not since it is typed as Record<string, string>, and the error is most likely introduced here. That is why any is dangerous.

from obsidian_supercharged_links.

FeralFlora avatar FeralFlora commented on July 18, 2024 1

The update seems to have resolved this. I can now open notes with banners again.

from obsidian_supercharged_links.

mProjectsCode avatar mProjectsCode commented on July 18, 2024

Disclaimer: I am not a dev or user of this plugin.

The stack trace points to obsidian-hover-editor and obsidian-banners. What happens if you disable these?

from obsidian_supercharged_links.

FeralFlora avatar FeralFlora commented on July 18, 2024

Disclaimer: I am not a dev or user of this plugin.

The stack trace points to obsidian-hover-editor and obsidian-banners. What happens if you disable these?

I'm not sure, but before I try that, note that:

  • If I disable Supercharged links, I can open the note without issue.
  • After downgrading to the previous version of Supercharged links, I can open the note without issue with Supercharged links enabled.
  • startsWith is part of the changed code in the last update.

Actually, I won't be testing that just now, because I've downgraded for now.

from obsidian_supercharged_links.

FeralFlora avatar FeralFlora commented on July 18, 2024

Disclaimer: I am not a dev or user of this plugin.

The stack trace points to obsidian-hover-editor and obsidian-banners. What happens if you disable these?

It's likely that version 0.11.0 of Supercharged Links has some bad interaction with Banners, since I only had the issue of not being able to open the note, when the note had a banner. But again, the previous version works fine with banners.

from obsidian_supercharged_links.

HEmile avatar HEmile commented on July 18, 2024

Hi there, oops, that doesn't look good. I agree @mProjectsCode with your first observation. @FeralFlora can you check out v0.11.1?

from obsidian_supercharged_links.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.