Comments (6)
stewSquared
commented on May 30, 2024
I should note that the rest of the Plans API looks really good. Thanks a lot! This library is saving me a ton of trouble.
from stripe-scala.
leonardehrenfried
commented on May 30, 2024
Neither @mdedetrich or myself are actively adding features to this library but we would welcome pull requests with tests. There are already quite a few unit/integration tests around so just copy what you see there.
from stripe-scala.
stewSquared
commented on May 30, 2024
@leonardehrenfried Sure thing! I don't think it's too much effort to provide fixes myself.
How actively are you two reviewing PRs and cutting releases? I've found a couple more subtle bugs since I posted the issue last night.
from stripe-scala.
leonardehrenfried
commented on May 30, 2024
I usually review within 1 or 2 days.
Matthew cuts the releases in the end and sometimes needs a little more
prodding but it shouldn't be more than a few days.
Am 16.03.2018 11:23 schrieb "Stewart Stewart" <[email protected]>:
… @leonardehrenfried <https://github.com/leonardehrenfried> Sure thing! I
don't think it's too much effort to provide fixes myself.
How actively are you two reviewing PRs and cutting releases? I've found a
couple more subtle bugs since I posted the issue last night.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJPMiuE8YQldQ0cvKnS3erIUc_VwGr2ks5te5KqgaJpZM4StJ3M>
.
from stripe-scala.
mdedetrich
commented on May 30, 2024
If you submit a PR I can easily review and merge.
from stripe-scala.
stewSquared
commented on May 30, 2024
@mdedetrich @leonardehrenfried
Sounds great! I'll submit something later today.
from stripe-scala.
Related Issues (19)
- Serialize double nested object into post form data? HOT 1
- Deploy to Maven Central HOT 7
- Migrate to akka-http client
- Investigate DI (use case classes instead of objects?) HOT 1
- Change from play-json to a better JSON client HOT 3
- ApiKey Configuration HOT 2
- Remove scala-uri dependency
- Set Stripe-Version header
- Use default named parameters
- sbt-release being weird?
- sbt-release being weird? HOT 4
- ChargeInput only accepts CreditCard and not token HOT 3
- Plan listing tries to fetch customer HOT 3
- cats-core version conflicts - upgrading circe-core to 0.9.2 HOT 2
- Support brand in charge source HOT 1
- Fatal Warnings HOT 2
- Update dependencies HOT 2
- Delete Subscription HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stripe-scala.