Add Travis support about timezone-js HOT 6 CLOSED

Let me know if you need me to push a version to NPM.

from timezone-js.

Yup I think everything's clear. The failing unit test was a coincidence since the test use my local timezone :) Thanks for the catch. I think using a CI will avoid this kind of situation.

Feel free to push 0.4.2 to npm. :)

from timezone-js.

Actually 0.4.3, pushed. :) Ah, it's a dot-file. I didn't notice the leading dot, so I wasn't seeing the file. Nice work getting it hooked up to CI.

And yes, I can remember tripping over the coincidental local-timezone-match problem before. Would be awesome if we could somehow add an explicit test for that scenario.

from timezone-js.

For the Travis CI support actually only the admin can do it so you probably will have go to travis-ci.org and flip the switch.

For the timezone match issue I can probably specify each test to run through a list of certain timezones over the world. What do you think?

from timezone-js.

Had to make some tweaks so CI would run. Looks like we're green!

The accidental-match problem happens when the OS timezone happens to match the expected result in the test, right? Maybe a conditional assert that checks for either a match if the offset happens to be the same, or a thrown error if it's not?

from timezone-js.

Hmm that and also the case when developers make test cases that use the OS timezones. It my bad on my part that I used America/New_York for the failing test and didn't realize until I switched to America/Los_Angeles or Asia/Bangkok. Prob I should note down to explicitly test some timezones other than my local one?

from timezone-js.