Code Monkey home page Code Monkey logo

Comments (11)

FezVrasta avatar FezVrasta commented on May 18, 2024

I'm aware of this problem but I can't find what is the error...

from mdb-ui-kit.

waylaidwanderer avatar waylaidwanderer commented on May 18, 2024

I found the source of the problem. document.dispatchEvent seems to be unreliable. I've tested a fix that seems to work and I'll make a pull request once you've looked at #21.

from mdb-ui-kit.

FezVrasta avatar FezVrasta commented on May 18, 2024

Still open to PRs for this bug.

from mdb-ui-kit.

roeku avatar roeku commented on May 18, 2024

Well i too noticed this when i first came in contact with this git. I didn't make an issue of it because when you click on a button it's supposed to perform an action which would negate a user spamclicking a button. Don't get me wrong it would be better if it didn't bug out but looking at it from a UI perspective i don't consider it an issue.

from mdb-ui-kit.

FezVrasta avatar FezVrasta commented on May 18, 2024

It can cause problems if you apply the ripple effect to something that is not a link (an image, a dropdown toggle etc)

I'd very like to fix this problem :/

from mdb-ui-kit.

shak18 avatar shak18 commented on May 18, 2024

this could help you fix the issue there are 4 great approaches to ripple and doesnt seem to have that bug

http://codepen.io/madshaakansson/pen/ykode

http://codepen.io/KrisOlszewski/pen/Dnktj

http://codepen.io/Craigtut/pen/dIfzv

http://codepen.io/idiotWu/pen/nefhC

hope it can help cause youre making a great job with this :)

from mdb-ui-kit.

FezVrasta avatar FezVrasta commented on May 18, 2024

All of them have a trouble, when you hold the mouse down the ripple does not stay active. And this is the difficult part of my script which makes it different and(possibly) better than others

from mdb-ui-kit.

aarohmankad avatar aarohmankad commented on May 18, 2024

Has this since been fixed? I can't seem to replicate the issue.

from mdb-ui-kit.

ezpuzz avatar ezpuzz commented on May 18, 2024

Definitely gets darker after repeated clicks for me in FF33, I like that last example shak18 posted.

from mdb-ui-kit.

waylaidwanderer avatar waylaidwanderer commented on May 18, 2024

I've submitted a pull request that should fix this problem.

from mdb-ui-kit.

waylaidwanderer avatar waylaidwanderer commented on May 18, 2024

I've updated the pull request to allow multiple ripples to animate while still removing old ripples correctly.

from mdb-ui-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.