remapping overloaded field names (matching on field descriptor) about specialsource HOT 8 OPEN

👍 This happened when I did my CraftBukkit update

from specialsource.

@mrapple hm are you sure, what specific symbols were problematic? I've only seen this when deobfuscating obfuscated CB, AFAIK it only occurs when a subclass references a field from its superclass which was private in vanilla but was edited for greater visibility and the obfuscated name happens to collide with another field in a subclass (specific example in FML issue 210, but could also occur with coremods using access transformers).

from specialsource.

Can't remember exactly, but it's the case you describe. A field that was edited in a superclass.

from specialsource.

FWIW, FML now includes this feature, for its runtime deobfuscation (the field type info is looked up dynamically).

from specialsource.

Overloaded field in 1.5.2 (noted while debugging MCPC+):

FD: net/minecraft/entity/EntityLiving/potionsNeedUpdate net/minecraft/entity/EntityLiving/field_70752_e
FD: net/minecraft/entity/player/EntityPlayerMP/playerInventoryBeingManipulated net/minecraft/entity/player/EntityPlayerMP/field_71137_h

FD: net/minecraft/entity/player/EntityPlayerMP/playerInventoryBeingManipulated jc/h
FD: net/minecraft/entity/EntityLiving/potionsNeedUpdate ng/h

from specialsource.

MinecraftPortCentral/Cauldron@e447c52

from specialsource.

Also, this occurred again during the 1.6 update. How do we fix this?

from specialsource.

Does this relate to #3? When it's fixed will this be fixed?

from specialsource.