Comments (3)
Hallo cage,
thanks for the finding. This is clearly a mistake. The intention of the commit was to make the dialog properly render with a without a window border with the curent item prefix taken into account. The default width of the message should depend on the width of the dialog window, not on the number or layout of the buttons, that is true.
Instead of just
:width width
it should account for a border:
:width (- width (+ 2 (* 2 padding)))
Do you agree? If you do, I'll push that. If you have a better idea, please tell.
I am in general not all too happy with the pad object containing the message. I did this a long time ago and I think that it can be greatly simplified. The dialog window should in the future be bassed on form-window instead of menu-window, so we can add input fields, checkboxes and buttons. It is only based on menu-window because it was added before I started adding form elements.
from croatoan.
from croatoan.
Fixed in 5764605
from croatoan.
Related Issues (20)
- Missing a way to check if a window was deleted HOT 3
- Question build a cli interface using croatoan HOT 2
- wrong information in docstring HOT 2
- Compile /src/util.lisp HOT 2
- Issue with wbkgrnd when upgrading from ncurses 6.1 to 6.2 HOT 13
- apparently unicode support was lost with sbcl 2.0.3 HOT 7
- Does not build - ncurses issue HOT 2
- support for 24bit color HOT 6
- Missing 'raise-to-top' HOT 6
- proposing for some helpers function for complex-string HOT 4
- Last char drawn to menu choice to not be last char of string HOT 2
- Class hierarchy and naming of position slots/accessors HOT 7
- Foreign library definitions missing for MS Windows HOT 3
- [help] Using mouse event with bind HOT 19
- Documentation HOT 4
- Tags and releases HOT 11
- Lisp warnings rendered in ncurses application after connecting to the REPL HOT 6
- #\horizontal_ellipsis is not recognized by some implementations HOT 2
- Compilation issue with last commit HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from croatoan.