mcooper12590 / cavexc Goto Github PK

The formula used to calculate XC area CrossSection.calcA() breaks down under certain conditions. It works for any closed shape if the zero coordinate of the XC is within the shape. However, it only works for vadose wet cross-sections if the zero of the cross-section coordinate system is located at the water surface (i.e. y=0 is the water surface). I couldn't tell whether the vadose simulation code somehow corrects for this by resetting the zero. In any case, it would be more robust to do this check, or correction, within the calcA function. The formula can be corrected by subtracting out the y coord of the water surface (or max y coord in the case of only a wet cross-section).