Comments (5)
That's what would need to be changed:
Lines 107 to 116 in ac8169c
I would also recommend to modernize this using node core utility for parsing arguments.
from autocannon.
Is it ok for you having a breaking change with the cli ?
from autocannon.
If we can support commands (as aliases) that would be great. If not I'm happy to support the brekage, but I would like to see the impact before confirming.
from autocannon.
I had a parameters review. Some conflicts would be excellent to resolve somehow. Here is a recap below:
--data
is used to send the request body. Nowautocannon
only handles-b
, so I added it as an alias- if the request body is present, the request method is set to POST if not explicitly given. I put the method to POST if
body
is given. breaking change -v
puts the curl in debug mode, dumping the request (whole request, not just the body) and the response (whole response, not just the body). Instead,autocannon
uses this parameter as an alias of--version
. breaking change--data @filepath
is not supported by autocannon. possible breaking change-X
is used to specify the http request method. I put it as an alias- I don't want to support
--location
because it could be hard to implement. Anyway,autocannon
ignores unknown parameters, so it is okay. - By default,
--data
putsapplication/x-www-form-urlencoded
as the content type. --data
if read from a file, remove all the\n
and similar stuff.--data-binary
sends the data as is without removing\n
and similar stuff.
Considering the above list, I see two ways to avoid a breaking change:
a. use a different node bin, like autocannon-curl
b. put a --curl-compatibility
(or similar) parameter to tell autocannon to parse the parameters as curl
-like params.
c. put a --from-curl-command
parameter to tell the rest of the strings are a curl command. Just an example autocannon -c 10 -d 10 --from-curl-command curl -X POST -d @foo "https://httpbin.org/anything" -H "accept: application/json"
. This will used the parameters before the --from-curl-command
as autocannon parameters, the after ones as curl parameters.
I also started the implementation. If you are interested, I'll also open a PR!
Let me know how you prefer to proceed.
from autocannon.
I don't see any major disruption here. I'm ok to ship a major with those changes.
from autocannon.
Related Issues (20)
- Feature: adding the whole response to verifyBody callback HOT 1
- Cannot make setupRequest function async HOT 1
- [Question]: not able to generate more than ~20 RPS HOT 5
- headers format HOT 1
- Cannot specify body for `PUT` request via CLI HOT 2
- Plans to update `@types/autocannon`? HOT 1
- Result shows 0 data HOT 3
- Traefik ignores autocannon when setting Host header HOT 1
- Icon without text HOT 1
- Can't print results with printResults HOT 1
- How to use aggregateResult?
- External script or websocket support HOT 1
- 7.15.0 not published to npm HOT 1
- Is there a way to generate a url for each request? HOT 3
- How to set 'keepalive' ? HOT 1
- Non-http usage? For CLI? HOT 1
- status code option HOT 5
- Arg parsing fails if URL ends with `]` HOT 15
- Investigate and fix failing test on windows with node 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autocannon.