Code Monkey home page Code Monkey logo

Comments (5)

mcollina avatar mcollina commented on June 10, 2024 1

That's what would need to be changed:

autocannon/autocannon.js

Lines 107 to 116 in ac8169c

let argv = subarg(argvs, {
boolean: ['json', 'n', 'help', 'renderLatencyTable', 'renderProgressBar', 'renderStatusCodes', 'forever', 'idReplacement', 'excludeErrorStats', 'onPort', 'debug', 'ignoreCoordinatedOmission', 'verbose'],
alias,
default: defaults,
'--': true
})
// subarg does not convert aliases in sub arguments
argv = generateSubArgAliases(argv)
argv.url = argv._.length > 1 ? argv._ : argv._[0]
.

I would also recommend to modernize this using node core utility for parsing arguments.

from autocannon.

allevo avatar allevo commented on June 10, 2024

Is it ok for you having a breaking change with the cli ?

from autocannon.

mcollina avatar mcollina commented on June 10, 2024

If we can support commands (as aliases) that would be great. If not I'm happy to support the brekage, but I would like to see the impact before confirming.

from autocannon.

allevo avatar allevo commented on June 10, 2024

I had a parameters review. Some conflicts would be excellent to resolve somehow. Here is a recap below:

  1. --data is used to send the request body. Now autocannon only handles -b, so I added it as an alias
  2. if the request body is present, the request method is set to POST if not explicitly given. I put the method to POST if body is given. breaking change
  3. -v puts the curl in debug mode, dumping the request (whole request, not just the body) and the response (whole response, not just the body). Instead, autocannon uses this parameter as an alias of --version. breaking change
  4. --data @filepath is not supported by autocannon. possible breaking change
  5. -X is used to specify the http request method. I put it as an alias
  6. I don't want to support --location because it could be hard to implement. Anyway, autocannon ignores unknown parameters, so it is okay.
  7. By default, --data puts application/x-www-form-urlencoded as the content type.
  8. --data if read from a file, remove all the \n and similar stuff.
  9. --data-binary sends the data as is without removing \n and similar stuff.

Considering the above list, I see two ways to avoid a breaking change:
a. use a different node bin, like autocannon-curl
b. put a --curl-compatibility (or similar) parameter to tell autocannon to parse the parameters as curl-like params.
c. put a --from-curl-command parameter to tell the rest of the strings are a curl command. Just an example autocannon -c 10 -d 10 --from-curl-command curl -X POST -d @foo "https://httpbin.org/anything" -H "accept: application/json". This will used the parameters before the --from-curl-command as autocannon parameters, the after ones as curl parameters.

I also started the implementation. If you are interested, I'll also open a PR!

Let me know how you prefer to proceed.

from autocannon.

mcollina avatar mcollina commented on June 10, 2024

I don't see any major disruption here. I'm ok to ship a major with those changes.

from autocannon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.