Comments (12)
What version of Foundry and which system (and version of the system) and which version of polyglot ?
Find the Culprit may have been able to identify the cause as being Polyglot but can you confirm that enabling the module breaks journal entries and disabling it fixes it ? Is it possibly an incompatibility with another module that also needs to be enabled (i.e: did you test this with nothing but polyglot enabled) ?
It all looks good from my side both with 0.6.6 and 0.7.1
from fvtt-module-polyglot.
Foundry is 0.6.6 running on a RasPi 4b 2GB, Polyglot 1.1.1
I've run with only Polyglot active and the problem persists.
from fvtt-module-polyglot.
I can't reproduce it and you're the first one to mention this issue.
What browser are you using and did you try a different browser? Although that shouldn't really matter since you say it works without the module...
Can you press F12 to open the dev console in Foundry and see if there's any errors in the console when you try to edit a journal entry ? If there is, please screenshot the console.
from fvtt-module-polyglot.
It occurs on both Firefox and Chrome and in both the OSE and 5e module.
An error occurs, pasting text
theme.min.js:9 Uncaught TypeError: Cannot read property 'toLowerCase' of undefined
at N.customFormats (theme.min.js:9)
at theme.min.js:9
at it (theme.min.js:9)
at N (theme.min.js:9)
at uO (theme.min.js:9)
at N.customFormats (theme.min.js:9)
at theme.min.js:9
at it (theme.min.js:9)
at N (theme.min.js:9)
at uO (theme.min.js:9)
N.customFormats @ theme.min.js:9
(anonymous) @ theme.min.js:9
it @ theme.min.js:9
N @ theme.min.js:9
uO @ theme.min.js:9
N.customFormats @ theme.min.js:9
(anonymous) @ theme.min.js:9
it @ theme.min.js:9
N @ theme.min.js:9
uO @ theme.min.js:9
(anonymous) @ theme.min.js:9
map @ theme.min.js:9
aO @ theme.min.js:9
(anonymous) @ theme.min.js:9
FS.fire @ tinymce.min.js:9
fire @ tinymce.min.js:9
nS @ tinymce.min.js:9
fS @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
ir @ tinymce.min.js:9
o @ tinymce.min.js:9
Ca.loadScripts @ tinymce.min.js:9
Ca.loadQueue @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
e @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
ir @ tinymce.min.js:9
o @ tinymce.min.js:9
Ca.loadScripts @ tinymce.min.js:9
Ca.loadQueue @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
vS @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
xN.render @ tinymce.min.js:9
n @ tinymce.min.js:9
(anonymous) @ tinymce.min.js:9
ir @ tinymce.min.js:9
e @ tinymce.min.js:9
vo.executeHandlers @ tinymce.min.js:9
m @ tinymce.min.js:9
go @ tinymce.min.js:9
vo.bind @ tinymce.min.js:9
U @ tinymce.min.js:9
init @ tinymce.min.js:9
create @ foundry.js:14103
_createEditor @ foundry.js:4910
sheet._createEditor @ polyglot.js:401
button.onclick @ foundry.js:4897
Show 20 more frames****
from fvtt-module-polyglot.
Thank you, that was helpful! I'm able to reproduce this here now, by modifying the languages that Polyglot finds. I'm not sure though how you could have the situation where the bug happens.
That shouldn't affect, but do you have any custom languages set in the Polyglot settings ?
In the dev console, can you type the following commands and screenshot the result (make sure you click on the little arrow to the result) :
PolyGlot.languages
and then with both polyglot enabled and disabled :
CONFIG.DND5E.languages
Hopefully that helps me figure out what caused it. In the meantime, I can add a workaround so if it happens again, it won't affect the editor.
from fvtt-module-polyglot.
Will do!
CONFIG.DND5E.languages without
Please let me know if this isn't right/you need something else. I'm new to helping debug this sort of thing!
from fvtt-module-polyglot.
Thanks... this is... I don't know what to think of this, lol. You've been very helpful though in figuring it out!
Since it doesn't work for DND5E, and I noticed you mentioned OSE earlier, I just checked with the OSE system and I'm now getting the problem. I don't know if OSE changed something recently to the system that caused it to act that way, but this is indeed quite weird.
Maybe @mesfoliesludiques knows why the languages is an Array instead of an Object, and whether it's a new change or it was a bug from the start.
Note that you said dnd5e also had the problem, can you confirm if that's true ?
Anyway, I've made appropriate fixes to prevent this and made a new release (v1.1.2) which works now with OSE.
Thanks for reporting and in your patience in debugging this issue!
from fvtt-module-polyglot.
I'll respond with a check on 5e in the morning. Happy to help!
from fvtt-module-polyglot.
Hi !
I am pushing an update to OSE that should solve the issue. Let me know.
from fvtt-module-polyglot.
Thanks for the quick reaction!
I've fixed it with this : 579a866
I'll wait for your release and see how I can make it compatible with both old and new version.
from fvtt-module-polyglot.
I had an issue, my translation logic was faulty, you should not have to update anything !
from fvtt-module-polyglot.
Tested with both updates applied and it's working correctly now for me in both OSE and 5e!
from fvtt-module-polyglot.
Related Issues (20)
- text not parsing when module enabled HOT 2
- 17 warning about fonts! HOT 1
- Polyglot broken after 1.8.4.x update | Cyberpunk Red
- Polyglot seems broken on ProseMirror's journal pages? HOT 3
- Scrambled chat bubbles truncated
- [BUG] Polyglot - Language selection only shows other languages to GM. - Non-standard system. HOT 4
- Language Support for Worlds Without Number HOT 3
- Polyglot language dropdown not visible when logged into a game in Safari HOT 10
- Polyglot and chat bubbles HOT 3
- Can't add custom fonts directory HOT 2
- "Add Polyglot's fonts to Core" setting overwrites user-uploaded fonts HOT 1
- Sharing compendium entry in chat is broken when a language other than common is used HOT 6
- [Reopen #279] Sharing compendium entry in chat is broken when a language other than common is used HOT 1
- currentLanguageProvider erroring on migrated WWN save HOT 3
- Only Randomize Non-Alphanumerical Characters Option
- Randomized characters as a per language setting HOT 1
- Missing languages in Shadowrun 5e HOT 1
- "/me" doesn't work great with this module HOT 2
- Journal (and other object) titles as other language
- Everyone can read any language HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fvtt-module-polyglot.