Code Monkey home page Code Monkey logo

Comments (5)

mcharmas avatar mcharmas commented on August 17, 2024

Hi,
sometimes the design of android APIs make me very sad...

So how do you imagine such feature? Checkbox option that would generate deserialization in readFromParcel method instead of constructor would be enough?

from android-parcelable-intellij-plugin.

yuriymyronovych avatar yuriymyronovych commented on August 17, 2024

Yea, the API is definitely weird.

You may put the checkbox, thats an option. Another option might be to generate the parcelable exactly in the same way as google showed in Rect class(link in first post). In that way it should be compatible with both aidl and standard parcelable. It is not different much from the way you do it now, right?

from android-parcelable-intellij-plugin.

mcharmas avatar mcharmas commented on August 17, 2024

The problem I can see in solution from sample is calling non-final method from constructor that is generally bad practice. Making this method final would forbid inharitance of parcelable objects.
That's why I don't want to make it a default behaviour. I guess making this optional would be better solution.

To be honest I am not sure when I'll find time to implement this. If you need this asap maybe try to implement it and pull request? I'll be happy to review it and merge. The codebase of plugin shouldn't be hard to understand.

from android-parcelable-intellij-plugin.

yuriymyronovych avatar yuriymyronovych commented on August 17, 2024

I would do it at start, no problem, but I am afraid I moved from the project a month ago and don't need it anymore, sorry, it is up to you.

from android-parcelable-intellij-plugin.

koh-osug avatar koh-osug commented on August 17, 2024

I have added a pull request for this: #74

I have also released an updated version in the meanwhile to be manually installed: https://github.com/koh-osug/android-parcelable-intellij-plugin/releases/tag/v0.7.1

NOTE: this must be installed over the existing plugin, otherwise some hook seems to be missing.

I'n not familiar with the meaning of the field until-build in the plugin.xml but it might not work in later versions if IntelliJ is restricting this artificially by using this.

from android-parcelable-intellij-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.