Hi, just a short notice & a thing one might keep in mind: In case this package is

I typed so much text and now it jumped at me: <a href="https://github.com/mcabbott

Keep lazy loading of data in mind? about axiskeys.jl HOT 4 CLOSED

mcabbott commented on June 3, 2024

Keep lazy loading of data in mind?

from axiskeys.jl.

Comments (4)

mcabbott commented on June 3, 2024

It does try to get only the values to be printed (or a few more), in the making of fakearray here:
https://github.com/mcabbott/AxisKeys.jl/blob/master/src/show.jl#L80-L103
Do you think it ought to be further restricted somehow? Can it detect when this is or isn't going to be a problem?

from axiskeys.jl.

maxfreu commented on June 3, 2024

I typed so much text and now it jumped at me:
https://github.com/mcabbott/AxisKeys.jl/blob/master/src/show.jl#L84
is missing a size(A,2)-...! So it tries to get almost eeeeeverything along dim 2 ;-)

Also ind1 is one larger than h for even h I think, but thats maybe not so important.

from axiskeys.jl.

mcabbott commented on June 3, 2024

Oh well spotted, sorry about that. The intent was there!

from axiskeys.jl.

maxfreu commented on June 3, 2024

Hmmm something more is fishy here. I fixed it locally, but still get OOM errors. Probably the underlying driver is trying to load all the data in, since everything is bundled in one getindex call. So maybe one could split it up into four calls manually and reassemble it.

Seems like array accesses have to be contiguous for GDAL: vrt[[1,2],[1,2],:] works, but vrt[[1,end],[1,end],:] doesn't (where vrt is some large ArchGDAL.RasterDataset).

from axiskeys.jl.

Recommend Projects