Tables.columntable return value about axiskeys.jl HOT 4 CLOSED

Thanks for taking a look, this is all very much a first attempt, and I'm sure it could be better.

Tables.columnsreturns a view for the :value column, but the others it makes new arrays, as a comprehension using Iterators.product. Is there an obvious lazy object that could be used? From my comments it looks like (1) a generator is insufficient, and (2) I didn't want to depend on Kronecker.jl or something, just to get a lazy product.

Ah, perhaps you are saying that each column then wants to be wrapped in Tables.CopiedColumns? That would be simple.

from axiskeys.jl.

Given your comment I think you can leave things as-is, and we have to copy columns of this NamedTuple when creating a DataFrame.

A small note is that using vec it is non obvoius that you are sharing data with the source. Probably it would be good to document it (if it is not documented already).

From DataFrames.jl this issue can be closed (so I am closing it). Thank you!

from axiskeys.jl.

Wait it seems like this ought to be consistent at least, and not make a view of just one column, without flagging things? If adding Tables.CopiedColumns would help that would be super-easy.

from axiskeys.jl.

I think Tables.CopiedColumns can be omitted - it was initially designed only for cases when Tables.columntable were intended to create only a temporary object.

from axiskeys.jl.